Christopher Johnson (WMDE) has uploaded a new change for review.
https://gerrit.wikimedia.org/r/232001
Change subject: reverts change from method setViewer back to setUser because of
upstream inconsistency
......................................................................
reverts change from method setViewer back to setUser because of upstream
inconsistency
there continues to be upstream confusion between "viewer" and "user", it seems
that ConduitAPIRequest does not support "viewer"...
Change-Id: I03e9b9c625d3ae86f222d1e901cd6afb29080888
---
M src/conduit/SprintCreateConduitAPIMethod.php
M src/conduit/SprintGetStartEndDatesConduitAPIMethod.php
M src/conduit/SprintGetTaskProjectHistoryConduitAPIMethod.php
M src/conduit/SprintSetIsSprintConduitAPIMethod.php
M src/conduit/SprintSetStartEndDatesConduitAPIMethod.php
5 files changed, 5 insertions(+), 5 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/phabricator/extensions/Sprint
refs/changes/01/232001/1
diff --git a/src/conduit/SprintCreateConduitAPIMethod.php
b/src/conduit/SprintCreateConduitAPIMethod.php
index 266b0bc..920e40b 100644
--- a/src/conduit/SprintCreateConduitAPIMethod.php
+++ b/src/conduit/SprintCreateConduitAPIMethod.php
@@ -28,7 +28,7 @@
}
protected function execute(ConduitAPIRequest $request) {
- $user = $request->getViewer();
+ $user = $request->getUser();
$this->requireApplicationCapability(
ProjectCreateProjectsCapability::CAPABILITY,
diff --git a/src/conduit/SprintGetStartEndDatesConduitAPIMethod.php
b/src/conduit/SprintGetStartEndDatesConduitAPIMethod.php
index 6beb024..f841dd2 100644
--- a/src/conduit/SprintGetStartEndDatesConduitAPIMethod.php
+++ b/src/conduit/SprintGetStartEndDatesConduitAPIMethod.php
@@ -25,7 +25,7 @@
}
protected function execute(ConduitAPIRequest $request) {
- $user = $request->getViewer();
+ $user = $request->getUser();
$query = id(new SprintQuery())
->setViewer($user);
$project = id(new PhabricatorProjectQuery())
diff --git a/src/conduit/SprintGetTaskProjectHistoryConduitAPIMethod.php
b/src/conduit/SprintGetTaskProjectHistoryConduitAPIMethod.php
index f02d5e1..393cc15 100644
--- a/src/conduit/SprintGetTaskProjectHistoryConduitAPIMethod.php
+++ b/src/conduit/SprintGetTaskProjectHistoryConduitAPIMethod.php
@@ -25,7 +25,7 @@
}
protected function execute(ConduitAPIRequest $request) {
- $user = $request->getViewer();
+ $user = $request->getUser();
$this->requireApplicationCapability(
ProjectCreateProjectsCapability::CAPABILITY,
diff --git a/src/conduit/SprintSetIsSprintConduitAPIMethod.php
b/src/conduit/SprintSetIsSprintConduitAPIMethod.php
index cc1d953..cd7fd91 100644
--- a/src/conduit/SprintSetIsSprintConduitAPIMethod.php
+++ b/src/conduit/SprintSetIsSprintConduitAPIMethod.php
@@ -26,7 +26,7 @@
}
protected function execute(ConduitAPIRequest $request) {
- $user = $request->getViewer();
+ $user = $request->getUser();
$this->requireApplicationCapability(
ProjectCreateProjectsCapability::CAPABILITY,
diff --git a/src/conduit/SprintSetStartEndDatesConduitAPIMethod.php
b/src/conduit/SprintSetStartEndDatesConduitAPIMethod.php
index dfd0e8a..f957b60 100644
--- a/src/conduit/SprintSetStartEndDatesConduitAPIMethod.php
+++ b/src/conduit/SprintSetStartEndDatesConduitAPIMethod.php
@@ -27,7 +27,7 @@
}
protected function execute(ConduitAPIRequest $request) {
- $user = $request->getViewer();
+ $user = $request->getUser();
$this->requireApplicationCapability(
ProjectCreateProjectsCapability::CAPABILITY,
--
To view, visit https://gerrit.wikimedia.org/r/232001
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I03e9b9c625d3ae86f222d1e901cd6afb29080888
Gerrit-PatchSet: 1
Gerrit-Project: phabricator/extensions/Sprint
Gerrit-Branch: master
Gerrit-Owner: Christopher Johnson (WMDE) <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
