Ankita-ks has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/232009

Change subject: Cleaning up the code : removing redundant functions and 
variables
......................................................................

Cleaning up the code : removing redundant functions and variables

Change-Id: Ib0021c2ff20e198f42bb1afad3cf9e0a08d94e32
---
M modules/ext.LanguageToolDialog.js
1 file changed, 5 insertions(+), 6 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/LanguageTool 
refs/changes/09/232009/1

diff --git a/modules/ext.LanguageToolDialog.js 
b/modules/ext.LanguageToolDialog.js
index 7c0f0e5..eb4a9d3 100644
--- a/modules/ext.LanguageToolDialog.js
+++ b/modules/ext.LanguageToolDialog.js
@@ -57,7 +57,6 @@
        this.$errors = $( '<div>' ).addClass( 
've-ui-findAndReplaceDialog-findResults' );
        this.initialFragment = null;
        this.fragments = [];
-       this.results = 0;
        // Range over the list of fragments indicating which ones where 
rendered,
        // e.g. [1,3] means fragments 1 & 2 were rendered
        this.renderedFragments = null;
@@ -247,11 +246,11 @@
 
        this.fragments.splice( this.focusedIndex, 1 );
        this.errors.splice( this.focusedIndex, 1 );
-       this.results = this.fragments.length;
-       this.focusedIndex = Math.min( this.focusedIndex, this.results ? 
this.results - 1 : 0 );
-       this.nextButton.setDisabled( !this.results );
-       this.previousButton.setDisabled( !this.results );
-       this.replaceButton.setDisabled( !this.results );
+       results = this.fragments.length;
+       this.focusedIndex = Math.min( this.focusedIndex, results ? results - 1 
: 0 );
+       this.nextButton.setDisabled( !results );
+       this.previousButton.setDisabled( !results );
+       this.replaceButton.setDisabled( !results );
 };
 
 /**

-- 
To view, visit https://gerrit.wikimedia.org/r/232009
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib0021c2ff20e198f42bb1afad3cf9e0a08d94e32
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/LanguageTool
Gerrit-Branch: master
Gerrit-Owner: Ankita-ks <[email protected]>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to