Jack Phoenix has submitted this change and it was merged.

Change subject: Version 2.3.1: responsiveness, moved one inline style to the 
CSS file
......................................................................


Version 2.3.1: responsiveness, moved one inline style to the CSS file

Bug: T87148
Change-Id: I4240e1bab6a3cf9de315c9e1d78dc0e6a4d2a5f7
---
M Blog.php
M SpecialCreateBlogPost.php
M resources/css/CreateBlogPost.css
3 files changed, 31 insertions(+), 15 deletions(-)

Approvals:
  Jack Phoenix: Looks good to me, approved



diff --git a/Blog.php b/Blog.php
index a5f1062..d8b32b6 100644
--- a/Blog.php
+++ b/Blog.php
@@ -5,20 +5,17 @@
  *
  * @file
  * @ingroup Extensions
- * @version 2.3
+ * @version 2.3.1
  * @author David Pean <[email protected]>
  * @author Jack Phoenix <[email protected]>
  * @license http://www.gnu.org/copyleft/gpl.html GNU General Public License 
2.0 or later
  * @link https://www.mediawiki.org/wiki/Extension:BlogPage Documentation
  */
-if ( !defined( 'MEDIAWIKI' ) ) {
-       die();
-}
 
 // Extension credits that will show up on Special:Version
 $wgExtensionCredits['other'][] = array(
        'name' => 'BlogPage',
-       'version' => '2.3',
+       'version' => '2.3.1',
        'author' => array( 'David Pean', 'Jack Phoenix' ),
        'descriptionmsg' => 'blogpage-desc',
        'url' => 'https://www.mediawiki.org/wiki/Extension:BlogPage',
@@ -29,36 +26,40 @@
 define( 'NS_BLOG_TALK', 501 );
 
 // ResourceLoader support for MediaWiki 1.17+
-$blogResourceTemplate = array(
-       'localBasePath' => __DIR__,
-       'remoteExtPath' => 'BlogPage'
-);
 
 // Main module, used on *all* blog pages (see the hooks file)
-$wgResourceModules['ext.blogPage'] = $blogResourceTemplate + array(
+$wgResourceModules['ext.blogPage'] = array(
        'styles' => 'resources/css/BlogPage.css',
+       'localBasePath' => __DIR__,
+       'remoteExtPath' => 'BlogPage',
        'position' => 'top'
 );
 
 // Used on Special:ArticlesHome & Special:ArticleLists
-$wgResourceModules['ext.blogPage.articlesHome'] = $blogResourceTemplate + 
array(
+$wgResourceModules['ext.blogPage.articlesHome'] = array(
        'styles' => 'resources/css/ArticlesHome.css',
+       'localBasePath' => __DIR__,
+       'remoteExtPath' => 'BlogPage',
        'position' => 'top'
 );
 
 // Used on Special:CreateBlogPost
-$wgResourceModules['ext.blogPage.create.css'] = $blogResourceTemplate + array(
+$wgResourceModules['ext.blogPage.create.css'] = array(
        'styles' => 'resources/css/CreateBlogPost.css',
+       'localBasePath' => __DIR__,
+       'remoteExtPath' => 'BlogPage',
        'position' => 'top'
 );
 
-$wgResourceModules['ext.blogPage.create.js'] = $blogResourceTemplate + array(
+$wgResourceModules['ext.blogPage.create.js'] = array(
        'scripts' => 'resources/js/CreateBlogPost.js',
        // 'dependencies' => 'mediawiki.action.edit',
        'messages' => array(
                'blog-js-create-error-need-content', 
'blog-js-create-error-need-title',
                'blog-js-create-error-page-exists'
-       )
+       ),
+       'localBasePath' => __DIR__,
+       'remoteExtPath' => 'BlogPage',
 );
 
 // Default setup for displaying sections
diff --git a/SpecialCreateBlogPost.php b/SpecialCreateBlogPost.php
index 7bbce8c..da3fe14 100644
--- a/SpecialCreateBlogPost.php
+++ b/SpecialCreateBlogPost.php
@@ -195,7 +195,7 @@
        public function displayFormPageTitle() {
                $output = '<span class="create-title">' . $this->msg( 
'blog-create-title' )->escaped() .
                        '</span><br /><input class="createbox" type="text" 
tabindex="' .
-                               $this->tabCounter . '" name="title2" id="title" 
style="width: 500px;"><br /><br />';
+                               $this->tabCounter . '" name="title2" 
id="title"><br /><br />';
                $this->tabCounter++;
                return $output;
        }
diff --git a/resources/css/CreateBlogPost.css b/resources/css/CreateBlogPost.css
index b155b49..8bd6bb0 100644
--- a/resources/css/CreateBlogPost.css
+++ b/resources/css/CreateBlogPost.css
@@ -7,6 +7,7 @@
 }
 
 .categorytext {
+       max-width: 100%;
        width: 700px;
 }
 
@@ -16,6 +17,7 @@
        width: 700px;
        color: rgb(51, 51, 51);
        font-size: 11px;
+       max-width: 100%;
 }
 
 #editform .title {
@@ -29,10 +31,23 @@
 #create-tagcloud {
        line-height: 25pt;
        padding-bottom: 15px;
+       max-width: 100%;
        width: 600px;
 }
 
 a.tag-cloud-entry {
        cursor: pointer;
        text-decoration: underline;
+}
+
+input#title {
+       width: 500px;
+}
+
+/* Normal low-end smartphones with a low resolution (i.e. Nokia X) */
+@media screen and (max-width: 750px) {
+       input#title {
+               /* Prevent the title input from overflowing */
+               max-width: 100%;
+       }
 }
\ No newline at end of file

-- 
To view, visit https://gerrit.wikimedia.org/r/232012
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I4240e1bab6a3cf9de315c9e1d78dc0e6a4d2a5f7
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/BlogPage
Gerrit-Branch: master
Gerrit-Owner: Jack Phoenix <[email protected]>
Gerrit-Reviewer: Jack Phoenix <[email protected]>
Gerrit-Reviewer: jenkins-bot <>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to