Alex Monk has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/232034

Change subject: Clear old captchas after building save options
......................................................................

Clear old captchas after building save options

Bug: T109113
Change-Id: Ib60b5c903c85106c92237d7ce47fa0c01e645a1d
---
M modules/ve-mw/init/ve.init.mw.Target.js
1 file changed, 3 insertions(+), 3 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/VisualEditor 
refs/changes/34/232034/1

diff --git a/modules/ve-mw/init/ve.init.mw.Target.js 
b/modules/ve-mw/init/ve.init.mw.Target.js
index 13ada45..4292420 100644
--- a/modules/ve-mw/init/ve.init.mw.Target.js
+++ b/modules/ve-mw/init/ve.init.mw.Target.js
@@ -1410,13 +1410,13 @@
                return false;
        }
 
+       var saveOptions = this.getSaveOptions();
+
        // Reset any old captcha data
        if ( this.captcha ) {
                this.saveDialog.clearMessage( 'captcha' );
                delete this.captcha;
        }
-
-       var saveOptions = this.getSaveOptions();
 
        if (
                +mw.user.options.get( 'forceeditsummary' ) &&
@@ -1435,7 +1435,7 @@
                if ( !this.docToSave ) {
                        this.docToSave = this.getSurface().getDom();
                }
-               this.save( this.docToSave, this.getSaveOptions() );
+               this.save( this.docToSave, saveOptions );
                this.saveDeferred = saveDeferred;
        }
 };

-- 
To view, visit https://gerrit.wikimedia.org/r/232034
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib60b5c903c85106c92237d7ce47fa0c01e645a1d
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/VisualEditor
Gerrit-Branch: wmf/1.26wmf18
Gerrit-Owner: Alex Monk <[email protected]>
Gerrit-Reviewer: Esanders <[email protected]>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to