Addshore has uploaded a new change for review.
https://gerrit.wikimedia.org/r/232045
Change subject: Push isWriteMode and needsToken methods down the API
......................................................................
Push isWriteMode and needsToken methods down the API
This is another step toward removing these base classes.
Bug: T71001
Change-Id: I4cc2e7c06b01e3c6946405e693c619b02abb56ad
---
M repo/includes/api/CreateClaim.php
M repo/includes/api/EditEntity.php
M repo/includes/api/ModifyClaim.php
M repo/includes/api/ModifyEntity.php
M repo/includes/api/RemoveClaims.php
M repo/includes/api/RemoveQualifiers.php
M repo/includes/api/RemoveReferences.php
M repo/includes/api/SetAliases.php
M repo/includes/api/SetClaim.php
M repo/includes/api/SetClaimValue.php
M repo/includes/api/SetDescription.php
M repo/includes/api/SetLabel.php
M repo/includes/api/SetQualifier.php
M repo/includes/api/SetReference.php
M repo/includes/api/SetSiteLink.php
15 files changed, 218 insertions(+), 34 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Wikibase
refs/changes/45/232045/1
diff --git a/repo/includes/api/CreateClaim.php
b/repo/includes/api/CreateClaim.php
index 3119beb..47099d6 100644
--- a/repo/includes/api/CreateClaim.php
+++ b/repo/includes/api/CreateClaim.php
@@ -122,6 +122,22 @@
}
/**
+ * @see ApiBase::isWriteMode
+ */
+ public function isWriteMode() {
+ return true;
+ }
+
+ /**
+ * @see ApiBase::needsToken
+ *
+ * @return string
+ */
+ public function needsToken() {
+ return 'csrf';
+ }
+
+ /**
* @see ApiBase::getAllowedParams
*/
protected function getAllowedParams() {
diff --git a/repo/includes/api/EditEntity.php b/repo/includes/api/EditEntity.php
index 68ebfa4..ca3c2a8 100644
--- a/repo/includes/api/EditEntity.php
+++ b/repo/includes/api/EditEntity.php
@@ -111,6 +111,24 @@
}
/**
+ * @see ApiBase::needsToken
+ *
+ * @return string
+ */
+ public function needsToken() {
+ return 'csrf';
+ }
+
+ /**
+ * @see ApiBase::isWriteMode()
+ *
+ * @return bool Always true.
+ */
+ public function isWriteMode() {
+ return true;
+ }
+
+ /**
* @param EntityDocument $entity
*
* @throws InvalidArgumentException
diff --git a/repo/includes/api/ModifyClaim.php
b/repo/includes/api/ModifyClaim.php
index d5faa32..98341ab 100644
--- a/repo/includes/api/ModifyClaim.php
+++ b/repo/includes/api/ModifyClaim.php
@@ -119,22 +119,6 @@
}
/**
- * @see ApiBase::isWriteMode
- */
- public function isWriteMode() {
- return true;
- }
-
- /**
- * @see ApiBase::needsToken
- *
- * @return string
- */
- public function needsToken() {
- return 'csrf';
- }
-
- /**
* @see ApiBase::getAllowedParams
*/
protected function getAllowedParams() {
diff --git a/repo/includes/api/ModifyEntity.php
b/repo/includes/api/ModifyEntity.php
index da6663b..7c7db57 100644
--- a/repo/includes/api/ModifyEntity.php
+++ b/repo/includes/api/ModifyEntity.php
@@ -516,24 +516,6 @@
}
/**
- * @see ApiBase::isWriteMode()
- *
- * @return bool Always true.
- */
- public function isWriteMode() {
- return true;
- }
-
- /**
- * @see ApiBase::needsToken
- *
- * @return string
- */
- public function needsToken() {
- return 'csrf';
- }
-
- /**
* @see ApiBase::getAllowedParams
*/
protected function getAllowedParams() {
diff --git a/repo/includes/api/RemoveClaims.php
b/repo/includes/api/RemoveClaims.php
index 4490890..e681d0a 100644
--- a/repo/includes/api/RemoveClaims.php
+++ b/repo/includes/api/RemoveClaims.php
@@ -158,6 +158,22 @@
}
/**
+ * @see ApiBase::isWriteMode
+ */
+ public function isWriteMode() {
+ return true;
+ }
+
+ /**
+ * @see ApiBase::needsToken
+ *
+ * @return string
+ */
+ public function needsToken() {
+ return 'csrf';
+ }
+
+ /**
* @see ApiBase::getAllowedParams
*/
protected function getAllowedParams() {
diff --git a/repo/includes/api/RemoveQualifiers.php
b/repo/includes/api/RemoveQualifiers.php
index 0a053d8..d7c18a6 100644
--- a/repo/includes/api/RemoveQualifiers.php
+++ b/repo/includes/api/RemoveQualifiers.php
@@ -130,6 +130,22 @@
}
/**
+ * @see ApiBase::isWriteMode
+ */
+ public function isWriteMode() {
+ return true;
+ }
+
+ /**
+ * @see ApiBase::needsToken
+ *
+ * @return string
+ */
+ public function needsToken() {
+ return 'csrf';
+ }
+
+ /**
* @see ApiBase::getAllowedParams
*/
protected function getAllowedParams() {
diff --git a/repo/includes/api/RemoveReferences.php
b/repo/includes/api/RemoveReferences.php
index a445b3f..2c08640 100644
--- a/repo/includes/api/RemoveReferences.php
+++ b/repo/includes/api/RemoveReferences.php
@@ -137,6 +137,22 @@
}
/**
+ * @see ApiBase::isWriteMode
+ */
+ public function isWriteMode() {
+ return true;
+ }
+
+ /**
+ * @see ApiBase::needsToken
+ *
+ * @return string
+ */
+ public function needsToken() {
+ return 'csrf';
+ }
+
+ /**
* @see ApiBase::getAllowedParams
*/
protected function getAllowedParams() {
diff --git a/repo/includes/api/SetAliases.php b/repo/includes/api/SetAliases.php
index 335c544..325bcfe 100644
--- a/repo/includes/api/SetAliases.php
+++ b/repo/includes/api/SetAliases.php
@@ -53,6 +53,24 @@
}
/**
+ * @see ApiBase::needsToken
+ *
+ * @return string
+ */
+ public function needsToken() {
+ return 'csrf';
+ }
+
+ /**
+ * @see ApiBase::isWriteMode()
+ *
+ * @return bool Always true.
+ */
+ public function isWriteMode() {
+ return true;
+ }
+
+ /**
* @param EntityDocument $entity
*
* @throws InvalidArgumentException
diff --git a/repo/includes/api/SetClaim.php b/repo/includes/api/SetClaim.php
index 84a02a0..a63ae57 100644
--- a/repo/includes/api/SetClaim.php
+++ b/repo/includes/api/SetClaim.php
@@ -176,6 +176,22 @@
}
/**
+ * @see ApiBase::isWriteMode
+ */
+ public function isWriteMode() {
+ return true;
+ }
+
+ /**
+ * @see ApiBase::needsToken
+ *
+ * @return string
+ */
+ public function needsToken() {
+ return 'csrf';
+ }
+
+ /**
* @see ApiBase::getAllowedParams
*/
protected function getAllowedParams() {
diff --git a/repo/includes/api/SetClaimValue.php
b/repo/includes/api/SetClaimValue.php
index 3aa2c04..64921ea 100644
--- a/repo/includes/api/SetClaimValue.php
+++ b/repo/includes/api/SetClaimValue.php
@@ -89,6 +89,22 @@
}
/**
+ * @see ApiBase::isWriteMode
+ */
+ public function isWriteMode() {
+ return true;
+ }
+
+ /**
+ * @see ApiBase::needsToken
+ *
+ * @return string
+ */
+ public function needsToken() {
+ return 'csrf';
+ }
+
+ /**
* @see ApiBase::getAllowedParams
*/
protected function getAllowedParams() {
diff --git a/repo/includes/api/SetDescription.php
b/repo/includes/api/SetDescription.php
index 75c7962..69ce5f3 100644
--- a/repo/includes/api/SetDescription.php
+++ b/repo/includes/api/SetDescription.php
@@ -82,6 +82,24 @@
}
/**
+ * @see ApiBase::needsToken
+ *
+ * @return string
+ */
+ public function needsToken() {
+ return 'csrf';
+ }
+
+ /**
+ * @see ApiBase::isWriteMode()
+ *
+ * @return bool Always true.
+ */
+ public function isWriteMode() {
+ return true;
+ }
+
+ /**
* @see ApiBase::getExamplesMessages
*/
protected function getExamplesMessages() {
diff --git a/repo/includes/api/SetLabel.php b/repo/includes/api/SetLabel.php
index d13a111..725abda 100644
--- a/repo/includes/api/SetLabel.php
+++ b/repo/includes/api/SetLabel.php
@@ -82,6 +82,24 @@
}
/**
+ * @see ApiBase::needsToken
+ *
+ * @return string
+ */
+ public function needsToken() {
+ return 'csrf';
+ }
+
+ /**
+ * @see ApiBase::isWriteMode()
+ *
+ * @return bool Always true.
+ */
+ public function isWriteMode() {
+ return true;
+ }
+
+ /**
* @see ApiBase::getExamplesMessages
*/
protected function getExamplesMessages() {
diff --git a/repo/includes/api/SetQualifier.php
b/repo/includes/api/SetQualifier.php
index a79f1b0..c7825bb 100644
--- a/repo/includes/api/SetQualifier.php
+++ b/repo/includes/api/SetQualifier.php
@@ -151,6 +151,22 @@
}
/**
+ * @see ApiBase::isWriteMode
+ */
+ public function isWriteMode() {
+ return true;
+ }
+
+ /**
+ * @see ApiBase::needsToken
+ *
+ * @return string
+ */
+ public function needsToken() {
+ return 'csrf';
+ }
+
+ /**
* @see ApiBase::getAllowedParams
*/
protected function getAllowedParams() {
diff --git a/repo/includes/api/SetReference.php
b/repo/includes/api/SetReference.php
index 206e898..fe80095 100644
--- a/repo/includes/api/SetReference.php
+++ b/repo/includes/api/SetReference.php
@@ -166,6 +166,22 @@
}
/**
+ * @see ApiBase::isWriteMode
+ */
+ public function isWriteMode() {
+ return true;
+ }
+
+ /**
+ * @see ApiBase::needsToken
+ *
+ * @return string
+ */
+ public function needsToken() {
+ return 'csrf';
+ }
+
+ /**
* @see ApiBase::getAllowedParams
*/
protected function getAllowedParams() {
diff --git a/repo/includes/api/SetSiteLink.php
b/repo/includes/api/SetSiteLink.php
index 5754d2d..0a9daea 100644
--- a/repo/includes/api/SetSiteLink.php
+++ b/repo/includes/api/SetSiteLink.php
@@ -53,6 +53,24 @@
}
/**
+ * @see ApiBase::isWriteMode()
+ *
+ * @return bool Always true.
+ */
+ public function isWriteMode() {
+ return true;
+ }
+
+ /**
+ * @see ApiBase::needsToken
+ *
+ * @return string
+ */
+ public function needsToken() {
+ return 'csrf';
+ }
+
+ /**
* Checks whether the link should be removed based on params
*
* @param array $params
--
To view, visit https://gerrit.wikimedia.org/r/232045
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I4cc2e7c06b01e3c6946405e693c619b02abb56ad
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Addshore <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
