20after4 has uploaded a new change for review.
https://gerrit.wikimedia.org/r/232062
Change subject: Handle application transactions with null data.
......................................................................
Handle application transactions with null data.
Several broken phabricator transactions are lingering in the queue.
This handles the case where the task has no associated data so that
the task will get a permanent failure instead of needlessly retrying
tasks that are hopelessly broken and have no chance of success, ever.
Change-Id: Ief36787e823d8707d6e692f5393e48ed121b2a21
---
M
src/applications/transactions/worker/PhabricatorApplicationTransactionPublishWorker.php
1 file changed, 6 insertions(+), 0 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/phabricator/phabricator
refs/changes/62/232062/1
diff --git
a/src/applications/transactions/worker/PhabricatorApplicationTransactionPublishWorker.php
b/src/applications/transactions/worker/PhabricatorApplicationTransactionPublishWorker.php
index ce1166f..e22a498 100644
---
a/src/applications/transactions/worker/PhabricatorApplicationTransactionPublishWorker.php
+++
b/src/applications/transactions/worker/PhabricatorApplicationTransactionPublishWorker.php
@@ -29,7 +29,13 @@
$data = $this->getTaskData();
$viewer = PhabricatorUser::getOmnipotentUser();
+ if (!$data) {
+ throw new PhabricatorWorkerPermanentFailureException(
+ pht('Task has no data!'));
+ }
+
$phid = idx($data, 'objectPHID');
+
if (!$phid) {
throw new PhabricatorWorkerPermanentFailureException(
pht('Task has no object PHID!'));
--
To view, visit https://gerrit.wikimedia.org/r/232062
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ief36787e823d8707d6e692f5393e48ed121b2a21
Gerrit-PatchSet: 1
Gerrit-Project: phabricator/phabricator
Gerrit-Branch: production
Gerrit-Owner: 20after4 <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
