jenkins-bot has submitted this change and it was merged.
Change subject: Further increase Theora transcode quality
......................................................................
Further increase Theora transcode quality
Improves quality visibly (if slightly) in scenes with motion,
without cranking up the bitrate further.
* re-enable two-pass encoding with ffmpeg2theora
* enable '--optimize' setting on ffmpeg2theora
Encodes slightly slower but still much faster than the WebM.
Change-Id: I056e399b925a42c871a436670b64df2369910de3
---
M WebVideoTranscode/WebVideoTranscode.php
M WebVideoTranscode/WebVideoTranscodeJob.php
2 files changed, 13 insertions(+), 4 deletions(-)
Approvals:
TheDJ: Looks good to me, approved
jenkins-bot: Verified
diff --git a/WebVideoTranscode/WebVideoTranscode.php
b/WebVideoTranscode/WebVideoTranscode.php
index 82db8c9..dc191bb 100644
--- a/WebVideoTranscode/WebVideoTranscode.php
+++ b/WebVideoTranscode/WebVideoTranscode.php
@@ -72,7 +72,8 @@
'samplerate' => '44100',
'channels' => '2',
'noUpscaling' => 'true',
- //'twopass' => 'true',
+ 'twopass' => 'true',
+ 'optimize' => 'true',
'keyframeInterval' => '128',
'bufDelay' => '256',
'videoCodec' => 'theora',
@@ -86,7 +87,8 @@
'samplerate' => '44100',
'channels' => '2',
'noUpscaling' => 'true',
- //'twopass' => 'true',
+ 'twopass' => 'true',
+ 'optimize' => 'true',
'keyframeInterval' => '128',
'bufDelay' => '256',
'videoCodec' => 'theora',
@@ -100,7 +102,8 @@
'samplerate' => '44100',
'channels' => '2',
'noUpscaling' => 'true',
- //'twopass' => 'true',
+ 'twopass' => 'true',
+ 'optimize' => 'true',
'keyframeInterval' => '128',
'bufDelay' => '256',
'videoCodec' => 'theora',
@@ -114,7 +117,8 @@
'samplerate' => '44100',
'channels' => '2',
'noUpscaling' => 'true',
- //'twopass' => 'true',
+ 'twopass' => 'true',
+ 'optimize' => 'true',
'keyframeInterval' => '128',
'bufDelay' => '256',
'videoCodec' => 'theora',
@@ -127,6 +131,8 @@
'videoQuality' => 6,
'audioQuality' => 3,
'noUpscaling' => 'true',
+ 'twopass' => 'true',
+ 'optimize' => 'true',
'keyframeInterval' => '128',
'videoCodec' => 'theora',
'type' => 'video/ogg;
codecs="theora, vorbis"',
@@ -138,6 +144,8 @@
'videoQuality' => 6,
'audioQuality' => 3,
'noUpscaling' => 'true',
+ 'twopass' => 'true',
+ 'optimize' => 'true',
'keyframeInterval' => '128',
'videoCodec' => 'theora',
'type' => 'video/ogg;
codecs="theora, vorbis"',
diff --git a/WebVideoTranscode/WebVideoTranscodeJob.php
b/WebVideoTranscode/WebVideoTranscodeJob.php
index 4014673..e1b4f55 100755
--- a/WebVideoTranscode/WebVideoTranscodeJob.php
+++ b/WebVideoTranscode/WebVideoTranscodeJob.php
@@ -924,6 +924,7 @@
'videoQuality'=> "-v",
'videoBitrate' => "-V",
'twopass' => "--two-pass",
+ 'optimize' => "--optimize",
'framerate' => "-F",
'aspect' => "--aspect",
'starttime' => "--starttime",
--
To view, visit https://gerrit.wikimedia.org/r/231521
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I056e399b925a42c871a436670b64df2369910de3
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/TimedMediaHandler
Gerrit-Branch: master
Gerrit-Owner: Brion VIBBER <[email protected]>
Gerrit-Reviewer: TheDJ <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
