Niedzielski has uploaded a new change for review. https://gerrit.wikimedia.org/r/232212
Change subject: Temporarily revert string renames ...................................................................... Temporarily revert string renames Temporarily revert string resource key names made in aca6ca981dca276c0f57d17768085bde5583c052. String contents may change, or strings added or removed, but string names must remain the same so TWN diffs may be resolved safely. Let this be a lesson in keeping patches small and a tale of caution that our translation diffs aren't terribly sophisticated. Devs may exclusively change string names or values in patch and in a day. The following reverts were made according to strings.xml[0]: menu_page_save -> menu_save_page menu_page_share -> menu_share_page snackbar_saving_page -> toast_saving_page snackbar_saved_page_format -> toast_saved_page snackbar_saved_page_missing_images -> toast_saved_page_missing_images snackbar_refresh_saved_page -> toast_refresh_saved_page snackbar_saved_page_deleted -> toast_saved_page_deleted menu_page_other_languages -> menu_other_languages menu_page_find_in_page -> find_in_page menu_page_font_and_theme -> menu_themechooser menu_page_show_tabs -> menu_show_tabs menu_long_press_open_page -> menu_open_link menu_long_press_open_in_new_tab -> menu_open_in_new_tab [0] https://gerrit.wikimedia.org/r/#/c/229582/9/app/src/main/res/values/strings.xml Change-Id: Id0294cc2b6035b61203ce8bbbeb13aa0cd50a914 --- M app/src/main/java/org/wikipedia/page/FindInPageActionProvider.java M app/src/main/java/org/wikipedia/page/PageActivity.java M app/src/main/java/org/wikipedia/page/PageFragment.java M app/src/main/java/org/wikipedia/page/snippet/ShareHandler.java M app/src/main/java/org/wikipedia/savedpages/SavedPagesFragment.java M app/src/main/res/layout/group_find_in_page.xml M app/src/main/res/menu/menu_page_actions.xml M app/src/main/res/menu/menu_page_long_press.xml M app/src/main/res/values-af/strings.xml M app/src/main/res/values-ak/strings.xml M app/src/main/res/values-ar/strings.xml M app/src/main/res/values-av/strings.xml M app/src/main/res/values-bn/strings.xml M app/src/main/res/values-br/strings.xml M app/src/main/res/values-ca/strings.xml M app/src/main/res/values-ce/strings.xml M app/src/main/res/values-cs/strings.xml M app/src/main/res/values-cy/strings.xml M app/src/main/res/values-da/strings.xml M app/src/main/res/values-de/strings.xml M app/src/main/res/values-el/strings.xml M app/src/main/res/values-eo/strings.xml M app/src/main/res/values-es/strings.xml M app/src/main/res/values-et/strings.xml M app/src/main/res/values-eu/strings.xml M app/src/main/res/values-fa/strings.xml M app/src/main/res/values-fi/strings.xml M app/src/main/res/values-fo/strings.xml M app/src/main/res/values-fr/strings.xml M app/src/main/res/values-gl/strings.xml M app/src/main/res/values-gu/strings.xml M app/src/main/res/values-hi/strings.xml M app/src/main/res/values-hu/strings.xml M app/src/main/res/values-ia/strings.xml M app/src/main/res/values-in/strings.xml M app/src/main/res/values-it/strings.xml M app/src/main/res/values-iw/strings.xml M app/src/main/res/values-ja/strings.xml M app/src/main/res/values-ji/strings.xml M app/src/main/res/values-ka/strings.xml M app/src/main/res/values-km/strings.xml M app/src/main/res/values-kn/strings.xml M app/src/main/res/values-ko/strings.xml M app/src/main/res/values-ku/strings.xml M app/src/main/res/values-kw/strings.xml M app/src/main/res/values-ky/strings.xml M app/src/main/res/values-lb/strings.xml M app/src/main/res/values-lt/strings.xml M app/src/main/res/values-mk/strings.xml M app/src/main/res/values-ml/strings.xml M app/src/main/res/values-mn/strings.xml M app/src/main/res/values-mr/strings.xml M app/src/main/res/values-ms/strings.xml M app/src/main/res/values-mt/strings.xml M app/src/main/res/values-my/strings.xml M app/src/main/res/values-nb/strings.xml M app/src/main/res/values-ne/strings.xml M app/src/main/res/values-nl/strings.xml M app/src/main/res/values-oc/strings.xml M app/src/main/res/values-om/strings.xml M app/src/main/res/values-or/strings.xml M app/src/main/res/values-pa/strings.xml M app/src/main/res/values-pl/strings.xml M app/src/main/res/values-ps/strings.xml M app/src/main/res/values-pt-rBR/strings.xml M app/src/main/res/values-pt/strings.xml M app/src/main/res/values-qq/strings.xml M app/src/main/res/values-ro/strings.xml M app/src/main/res/values-ru/strings.xml M app/src/main/res/values-sa/strings.xml M app/src/main/res/values-si/strings.xml M app/src/main/res/values-sk/strings.xml M app/src/main/res/values-sr/strings.xml M app/src/main/res/values-sv/strings.xml M app/src/main/res/values-sw/strings.xml M app/src/main/res/values-ta/strings.xml M app/src/main/res/values-te/strings.xml M app/src/main/res/values-th/strings.xml M app/src/main/res/values-tl/strings.xml M app/src/main/res/values-tr/strings.xml M app/src/main/res/values-uk/strings.xml M app/src/main/res/values-ur/strings.xml M app/src/main/res/values-uz/strings.xml M app/src/main/res/values-vi/strings.xml M app/src/main/res/values-zh-rTW/strings.xml M app/src/main/res/values-zh/strings.xml M app/src/main/res/values/strings-no-translate.xml M app/src/main/res/values/strings.xml 88 files changed, 802 insertions(+), 802 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/apps/android/wikipedia refs/changes/12/232212/1 -- To view, visit https://gerrit.wikimedia.org/r/232212 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Id0294cc2b6035b61203ce8bbbeb13aa0cd50a914 Gerrit-PatchSet: 1 Gerrit-Project: apps/android/wikipedia Gerrit-Branch: master Gerrit-Owner: Niedzielski <[email protected]> _______________________________________________ MediaWiki-commits mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
