Jdlrobson has uploaded a new change for review.
https://gerrit.wikimedia.org/r/232222
Change subject: Insert survey before thumb when present.
......................................................................
Insert survey before thumb when present.
Cautionary notes:
* Not clear what happens when put inside infobox
* The survey might be bigger than the thumbnails around it. We have no control
over the user content so this will have to be a tradeoff - we can't keep
consistent.
Bug: T107603
Change-Id: Ie48d716b870a10da820c766fece8b3e806003614
---
M resources/ext.quicksurveys.init/init.js
M resources/ext.quicksurveys.init/styles.less
2 files changed, 5 insertions(+), 1 deletion(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/QuickSurveys
refs/changes/22/232222/1
diff --git a/resources/ext.quicksurveys.init/init.js
b/resources/ext.quicksurveys.init/init.js
index aa0e168..37d40a0 100644
--- a/resources/ext.quicksurveys.init/init.js
+++ b/resources/ext.quicksurveys.init/init.js
@@ -27,7 +27,7 @@
if ( inSample || mw.util.getParamValue( 'quicksurvey' )
) {
$bodyContent = $( '#bodyContent' );
- $place = $bodyContent.find( 'h1, h2, h3, h4,
h5, h6' ).eq( 0 );
+ $place = $bodyContent.find( '.thumb, h1, h2,
h3, h4, h5, h6' ).eq( 0 );
if ( $place.length ) {
$panel.insertBefore( $place );
diff --git a/resources/ext.quicksurveys.init/styles.less
b/resources/ext.quicksurveys.init/styles.less
index 4455cea..ebc6dda 100644
--- a/resources/ext.quicksurveys.init/styles.less
+++ b/resources/ext.quicksurveys.init/styles.less
@@ -4,6 +4,10 @@
.ext-qs-loader-bar {
display: block;
height: 100px;
+ max-width: 500px;
+ margin-left: 1.4em;
+ clear: right;
+ float: right;
background-color: @colorGrayLightest;
&.mw-ajax-loader {
// FIXME: Why is this not the default? Override it.
--
To view, visit https://gerrit.wikimedia.org/r/232222
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ie48d716b870a10da820c766fece8b3e806003614
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/QuickSurveys
Gerrit-Branch: dev
Gerrit-Owner: Jdlrobson <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
