jenkins-bot has submitted this change and it was merged.
Change subject: Pass user to WikiPage::doEditContent from EditPage
......................................................................
Pass user to WikiPage::doEditContent from EditPage
This avoids the use of $wgUser inside of WikiPage::doEditContent.
It does not avoid the use of $wgUser in general, because EditPage does
not know about context, but it will make the indirect use visible and a
rewrite of EditPage can address the issue better.
Change-Id: Ifbcf52f2f076dc5c177bea22f90eb3b9fb8e3224
---
M includes/EditPage.php
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Legoktm: Looks good to me, approved
jenkins-bot: Verified
diff --git a/includes/EditPage.php b/includes/EditPage.php
index 0ca2f80..f3a41c4 100644
--- a/includes/EditPage.php
+++ b/includes/EditPage.php
@@ -1943,7 +1943,7 @@
$this->summary,
$flags,
false,
- null,
+ $wgUser,
$content->getDefaultFormat()
);
--
To view, visit https://gerrit.wikimedia.org/r/231548
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ifbcf52f2f076dc5c177bea22f90eb3b9fb8e3224
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Umherirrender <[email protected]>
Gerrit-Reviewer: Jackmcbarn <[email protected]>
Gerrit-Reviewer: Legoktm <[email protected]>
Gerrit-Reviewer: Tpt <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
