jenkins-bot has submitted this change and it was merged.
Change subject: Remove entity view loading spinner
......................................................................
Remove entity view loading spinner
Bug: T108365
Change-Id: I149e9f17b068ae0cf2cf9d824f3ac7497d8c1185
---
M repo/resources/wikibase.ui.entityViewInit.js
M view/resources/wikibase/wikibase.css
2 files changed, 0 insertions(+), 35 deletions(-)
Approvals:
Addshore: Checked; Looks good to me, approved
jenkins-bot: Verified
diff --git a/repo/resources/wikibase.ui.entityViewInit.js
b/repo/resources/wikibase.ui.entityViewInit.js
index f6b9414..baed7ed 100644
--- a/repo/resources/wikibase.ui.entityViewInit.js
+++ b/repo/resources/wikibase.ui.entityViewInit.js
@@ -7,16 +7,6 @@
( function( $, mw, wb, dataTypeStore, getExpertsStore, getFormatterStore,
getParserStore ) {
'use strict';
- // Show loading spinner as long as JavaScript is initialising.
- $( '.wikibase-entityview' ).addClass( 'loading' ).append(
- $( '<div/>' ).addClass( 'mw-small-spinner wb-entity-spinner' )
- );
- // Remove it after a while in any case, e.g. in case of an error.
- window.setTimeout( function() {
- $( '.wikibase-entityview' ).removeClass( 'loading' );
- $( '.wb-entity-spinner' ).remove();
- }, 7000 );
-
mw.hook( 'wikipage.content' ).add( function() {
if( mw.config.get( 'wbEntity' ) === null ) {
return;
@@ -38,10 +28,6 @@
attachAnonymousEditWarningTrigger( $entityview,
viewName, entity.getType() );
attachWatchLinkUpdater( $entityview, viewName );
}
-
- // Remove loading spinner after JavaScript has kicked
in:
- $entityview.removeClass( 'loading' );
- $( '.wb-entity-spinner' ).remove();
} );
if( canEdit ) {
diff --git a/view/resources/wikibase/wikibase.css
b/view/resources/wikibase/wikibase.css
index 832f012..6447e6e 100644
--- a/view/resources/wikibase/wikibase.css
+++ b/view/resources/wikibase/wikibase.css
@@ -139,27 +139,6 @@
color: #A1A1A1;
}
-.wikibase-entityview.loading {
- position: relative;
-}
-
-.wikibase-entityview.loading > * {
- opacity: .3;
-}
-
-.wb-entity-spinner { /* loading spinner positioning (animation is taken from
.mw-small-spinner) */
- display: none;
- left: 50%;
- margin-left: -10px; /* half of the 20px width of .mw-small-spinner */
- opacity: 1 !important;
- position: absolute;
- top: 120px;
-}
-
-.loading .wb-entity-spinner {
- display: block;
-}
-
.wb-entity-undefinedinfo {
color: #505050;
font-style: italic;
--
To view, visit https://gerrit.wikimedia.org/r/232246
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I149e9f17b068ae0cf2cf9d824f3ac7497d8c1185
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Thiemo Mättig (WMDE) <[email protected]>
Gerrit-Reviewer: Addshore <[email protected]>
Gerrit-Reviewer: Aude <[email protected]>
Gerrit-Reviewer: Hoo man <[email protected]>
Gerrit-Reviewer: Jonas Kress (WMDE) <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
