jenkins-bot has submitted this change and it was merged.
Change subject: Hygiene: give link preview menu items less ambiguous IDs
......................................................................
Hygiene: give link preview menu items less ambiguous IDs
These menu items should be more clearly identified with the link preview
dialog to prevent confusion with other, similarly ID'd items.
menu_save_page, in particular, is awfully close to menu_page_save (which
just cost me a short session in the debugger).
Change-Id: I5a41cba4f73714a136020e505a47df7ebde2b386
---
M app/src/main/java/org/wikipedia/page/linkpreview/LinkPreviewDialog.java
M app/src/main/res/menu/menu_link_preview.xml
2 files changed, 6 insertions(+), 6 deletions(-)
Approvals:
Dbrant: Looks good to me, approved
Niedzielski: Looks good to me, but someone else must approve
jenkins-bot: Verified
diff --git
a/app/src/main/java/org/wikipedia/page/linkpreview/LinkPreviewDialog.java
b/app/src/main/java/org/wikipedia/page/linkpreview/LinkPreviewDialog.java
index 980f7c5..e3aebf7 100755
--- a/app/src/main/java/org/wikipedia/page/linkpreview/LinkPreviewDialog.java
+++ b/app/src/main/java/org/wikipedia/page/linkpreview/LinkPreviewDialog.java
@@ -195,14 +195,14 @@
@Override
public boolean onMenuItemClick(MenuItem item) {
switch (item.getItemId()) {
- case R.id.menu_save_page:
+ case R.id.menu_link_preview_save_page:
overflowMenuHandler.onSavePage(pageTitle);
dismiss();
return true;
- case R.id.menu_share_page:
+ case R.id.menu_link_preview_share_page:
overflowMenuHandler.onShareLink(pageTitle);
return true;
- case R.id.menu_copy_url:
+ case R.id.menu_link_preview_copy_link:
overflowMenuHandler.onCopyLink(pageTitle);
dismiss();
return true;
diff --git a/app/src/main/res/menu/menu_link_preview.xml
b/app/src/main/res/menu/menu_link_preview.xml
index de27df2..4b3d93a 100644
--- a/app/src/main/res/menu/menu_link_preview.xml
+++ b/app/src/main/res/menu/menu_link_preview.xml
@@ -1,13 +1,13 @@
<?xml version="1.0" encoding="utf-8"?>
<menu xmlns:android="http://schemas.android.com/apk/res/android";>
- <item android:id="@+id/menu_save_page"
+ <item android:id="@+id/menu_link_preview_save_page"
android:title="@string/menu_link_preview_save_page"
/>
- <item android:id="@+id/menu_share_page"
+ <item android:id="@+id/menu_link_preview_share_page"
android:title="@string/menu_link_preview_share_page"
/>
- <item android:id="@+id/menu_copy_url"
+ <item android:id="@+id/menu_link_preview_copy_link"
android:title="@string/menu_link_preview_copy_link"
/>
</menu>
\ No newline at end of file
--
To view, visit https://gerrit.wikimedia.org/r/232178
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I5a41cba4f73714a136020e505a47df7ebde2b386
Gerrit-PatchSet: 1
Gerrit-Project: apps/android/wikipedia
Gerrit-Branch: master
Gerrit-Owner: Mholloway <[email protected]>
Gerrit-Reviewer: BearND <[email protected]>
Gerrit-Reviewer: Brion VIBBER <[email protected]>
Gerrit-Reviewer: Dbrant <[email protected]>
Gerrit-Reviewer: Niedzielski <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
