jenkins-bot has submitted this change and it was merged.
Change subject: Only show alien context for focusable nodes
......................................................................
Only show alien context for focusable nodes
Otherwise you can get a context for a paragraph.
Change-Id: I19247feb8f56509c9590c0260276f987d6304a09
---
M src/ui/contexts/ve.ui.LinearContext.js
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Jforrester: Looks good to me, approved
jenkins-bot: Verified
diff --git a/src/ui/contexts/ve.ui.LinearContext.js
b/src/ui/contexts/ve.ui.LinearContext.js
index 8388795..b8951c8 100644
--- a/src/ui/contexts/ve.ui.LinearContext.js
+++ b/src/ui/contexts/ve.ui.LinearContext.js
@@ -273,7 +273,7 @@
if ( !this.relatedSources.length ) {
selectedNode = surfaceModel.getSelectedNode();
// For now we only need alien contexts to show
the delete button
- if ( selectedNode && this.showDeleteButton() ) {
+ if ( selectedNode && selectedNode.isFocusable()
&& this.showDeleteButton() ) {
this.relatedSources.push( {
type: 'item',
embeddable:
ve.ui.contextItemFactory.isEmbeddable( 'alien' ),
--
To view, visit https://gerrit.wikimedia.org/r/232262
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I19247feb8f56509c9590c0260276f987d6304a09
Gerrit-PatchSet: 3
Gerrit-Project: VisualEditor/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Esanders <[email protected]>
Gerrit-Reviewer: Jforrester <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
