Alex Monk has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/232324

Change subject: Fix up GlobalUser's groupnotappliedhere styling
......................................................................

Fix up GlobalUser's groupnotappliedhere styling

Bug: T109483
Change-Id: I896a023d037886312ffd25b52cef7e01520126d5
---
M i18n/en.json
M i18n/qqq.json
M includes/specials/SpecialGlobalUsers.php
M modules/ext.centralauth.globalusers.css
4 files changed, 14 insertions(+), 4 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/CentralAuth 
refs/changes/24/232324/1

diff --git a/i18n/en.json b/i18n/en.json
index 29242df..c9a2297 100644
--- a/i18n/en.json
+++ b/i18n/en.json
@@ -181,6 +181,7 @@
        "centralauth-listusers-attached": "[[User:$1|exists locally]]",
        "centralauth-listusers-item": "[[Special:CentralAuth/$1|$1]] ($2)",
        "centralauth-listusers-nolocal": "unattached or doesn't exist locally",
+       "centralauth-listusers-groupnotappliedhere": "Group does not apply 
locally",
        "multilock": "Lock multiple global accounts",
        "centralauth-admin-multi-username": "Enter one or more usernames, 
separated by new-line",
        "centralauth-admin-multi-notfound": "Search returned no usernames.",
diff --git a/i18n/qqq.json b/i18n/qqq.json
index 2dccb29..7d89583 100644
--- a/i18n/qqq.json
+++ b/i18n/qqq.json
@@ -197,6 +197,7 @@
        "centralauth-listusers-attached": "This message is used as user's info. 
Parameters:\n* $1 - username\nSee also:\n* 
{{msg-mw|Centralauth-listusers-locked}}\n* 
{{msg-mw|Centralauth-listusers-attached}}\n* 
{{msg-mw|Centralauth-listusers-nolocal}}",
        "centralauth-listusers-item": "{{optional}}\nParameters:\n* $1 - 
username\n* $2 - list of informations. Can contain the following messages:\n** 
{{msg-mw|Centralauth-listusers-locked}}\n** 
{{msg-mw|Centralauth-listusers-attached}}\n** 
{{msg-mw|Centralauth-listusers-nolocal}}",
        "centralauth-listusers-nolocal": "This message is used as user's 
info:\n*{{msg-mw|centralauth-listusers-locked}}\n*{{msg-mw|centralauth-listusers-attached}}\n*{{msg-mw|centralauth-listusers-nolocal}}",
+       "centralauth-listusers-groupnotappliedhere": "This message is used as 
the tooltip for groups on [[Special:GlobalUsers]] which do not apply on the 
local wiki.",
        "multilock": "{{doc-special|MultiLock}}",
        "centralauth-admin-multi-username": "Instructions for text box where 
admin will enter usernames, one per line",
        "centralauth-admin-multi-notfound": "Error message when seach returned 
no results",
diff --git a/includes/specials/SpecialGlobalUsers.php 
b/includes/specials/SpecialGlobalUsers.php
index 657a94a..552fdb1 100644
--- a/includes/specials/SpecialGlobalUsers.php
+++ b/includes/specials/SpecialGlobalUsers.php
@@ -266,11 +266,18 @@
 
                $rights = array();
                foreach ( $result as $row2 ) {
+                       $groupLink = User::makeGroupLinkWiki( $row2->gug_group, 
User::getGroupMember( $row2->gug_group ) );
                        if ( isset( $this->wikiSets[$row2->gug_group] ) && 
!$this->wikiSets[$row2->gug_group]->inSet() ) {
-                               $group = User::makeGroupLinkWiki( 
$row2->gug_group, User::getGroupMember( $row2->gug_group ) );
-                               $rights[] = Html::element( 'span', array( 
'class' => 'groupnotappliedhere' ), $group );
+                               $rights[] = Html::element(
+                                       'span',
+                                       array(
+                                               'class' => 
'groupnotappliedhere',
+                                               'title' => $this->msg( 
'centralauth-listusers-groupnotappliedhere' )->plain()
+                                       ),
+                                       $groupLink
+                               );
                        } else {
-                               $rights[] = User::makeGroupLinkWiki( 
$row2->gug_group, User::getGroupMember( $row2->gug_group ) );
+                               $rights[] = $groupLink;
                        }
                }
 
diff --git a/modules/ext.centralauth.globalusers.css 
b/modules/ext.centralauth.globalusers.css
index 578bb1f..01cf9be 100644
--- a/modules/ext.centralauth.globalusers.css
+++ b/modules/ext.centralauth.globalusers.css
@@ -1,3 +1,4 @@
-.groupnotappliedhere {
+.groupnotappliedhere a {
         color: grey;
+        font-style: italic;
 }

-- 
To view, visit https://gerrit.wikimedia.org/r/232324
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I896a023d037886312ffd25b52cef7e01520126d5
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/CentralAuth
Gerrit-Branch: master
Gerrit-Owner: Alex Monk <[email protected]>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to