Ori.livneh has submitted this change and it was merged.
Change subject: Revert "Load all CSS in the top queue"
......................................................................
Revert "Load all CSS in the top queue"
Did not have a positive impact on perf.
This reverts commit b39755ebb400cfd79feef76d00725ce456bdcf7a.
Change-Id: I3b23fe09b08b188bd2290e91f58f93453d0a2677
---
M includes/OutputPage.php
1 file changed, 5 insertions(+), 1 deletion(-)
Approvals:
Ori.livneh: Verified; Looks good to me, approved
diff --git a/includes/OutputPage.php b/includes/OutputPage.php
index 80fd9ab..8d4720b 100644
--- a/includes/OutputPage.php
+++ b/includes/OutputPage.php
@@ -3073,6 +3073,10 @@
ResourceLoaderModule::TYPE_SCRIPTS
);
+ $links[] = $this->makeResourceLoaderLink(
$this->getModuleStyles( true, 'bottom' ),
+ ResourceLoaderModule::TYPE_STYLES
+ );
+
// Modules requests - let the client calculate dependencies and
batch requests as it likes
// Only load modules that have marked themselves for loading at
the bottom
$modules = $this->getModules( true, 'bottom' );
@@ -3664,7 +3668,7 @@
$otherTags = array(); // Tags to append after the normal <link>
tags
$resourceLoader = $this->getResourceLoader();
- $moduleStyles = $this->getModuleStyles( true );
+ $moduleStyles = $this->getModuleStyles( true, 'top' );
// Per-site custom styles
$moduleStyles[] = 'site';
--
To view, visit https://gerrit.wikimedia.org/r/232373
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I3b23fe09b08b188bd2290e91f58f93453d0a2677
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: wmf/1.26wmf19
Gerrit-Owner: Ori.livneh <[email protected]>
Gerrit-Reviewer: Daniel Friesen <[email protected]>
Gerrit-Reviewer: Ori.livneh <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
