jenkins-bot has submitted this change and it was merged.

Change subject: MediaWiki theme: Correct styling of nested buttons
......................................................................


MediaWiki theme: Correct styling of nested buttons

Imagine a ButtonWidget inside the popup of a PopupButtonWidget.
When pressed, this button would have the wrong color sometimes.

Change-Id: Ic3fc1970ce393394b2ba2aff4f0488b7948e0bff
---
M src/themes/mediawiki/elements.less
1 file changed, 2 insertions(+), 2 deletions(-)

Approvals:
  Jforrester: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/src/themes/mediawiki/elements.less 
b/src/themes/mediawiki/elements.less
index 58ac60e..8e5215b 100644
--- a/src/themes/mediawiki/elements.less
+++ b/src/themes/mediawiki/elements.less
@@ -244,7 +244,7 @@
        }
 
        &.oo-ui-widget-enabled {
-               .oo-ui-buttonElement-button:active,
+               > .oo-ui-buttonElement-button:active,
                &.oo-ui-buttonElement-pressed > .oo-ui-buttonElement-button {
                        color: @pressed;
                        border-color: @pressed;
@@ -276,7 +276,7 @@
        }
 
        &.oo-ui-widget-enabled {
-               .oo-ui-buttonElement-button:active,
+               > .oo-ui-buttonElement-button:active,
                &.oo-ui-buttonElement-pressed > .oo-ui-buttonElement-button {
                        color: @background;
                        background-color: @pressed;

-- 
To view, visit https://gerrit.wikimedia.org/r/231603
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ic3fc1970ce393394b2ba2aff4f0488b7948e0bff
Gerrit-PatchSet: 2
Gerrit-Project: oojs/ui
Gerrit-Branch: master
Gerrit-Owner: Bartosz DziewoƄski <[email protected]>
Gerrit-Reviewer: Catrope <[email protected]>
Gerrit-Reviewer: Jforrester <[email protected]>
Gerrit-Reviewer: jenkins-bot <>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to