jenkins-bot has submitted this change and it was merged.
Change subject: Fix another test tha fails spuriously
......................................................................
Fix another test tha fails spuriously
I believe this test failed for the same funky reasons as the last relevancy
test I fixed - jobs getting out of order due to clumping and not waiting long
enough for things to take effect.
Change-Id: I12d0ad9ca9bbd8186d6d1db9fc903e49f87335dd
---
M tests/browser/features/relevancy_api.feature
M tests/browser/features/support/hooks.rb
2 files changed, 9 insertions(+), 11 deletions(-)
Approvals:
Cindy-the-browser-test-bot: Looks good to me, but someone else must approve
EBernhardson: Looks good to me, approved
jenkins-bot: Verified
diff --git a/tests/browser/features/relevancy_api.feature
b/tests/browser/features/relevancy_api.feature
index 658866e..4830e13 100644
--- a/tests/browser/features/relevancy_api.feature
+++ b/tests/browser/features/relevancy_api.feature
@@ -62,14 +62,18 @@
And Relevancylanguagetest/en is the second api search result
And Relevancylanguagetest/ar is the third api search result
- @expect_failure
Scenario: Incoming links count in page weight
- When I api search for Relevancylinktest -intitle:link
- Then Relevancylinktest Larger Extraword is the first api search result
- And Relevancylinktest Smaller is the second api search result
- When I api search with disabled incoming link weighting for
Relevancylinktest -intitle:link
+ Given a page named Relevancylinktest Smaller exists
+ And a page named Relevancylinktest Larger Extraword exists
+ And a page named Relevancylinktest Larger/Link A exists with contents
[[Relevancylinktest Larger Extraword]]
+ And a page named Relevancylinktest Larger/Link B exists with contents
[[Relevancylinktest Larger Extraword]]
+ And a page named Relevancylinktest Larger/Link C exists with contents
[[Relevancylinktest Larger Extraword]]
+ And a page named Relevancylinktest Larger/Link D exists with contents
[[Relevancylinktest Larger Extraword]]
+ When within 20 seconds api searching for Relevancylinktest -intitle:link
yields Relevancylinktest Larger Extraword as the first result and
Relevancylinktest Smaller as the second result
+ And I api search with disabled incoming link weighting for
Relevancylinktest -intitle:link
Then Relevancylinktest Smaller is the first api search result
And Relevancylinktest Larger Extraword is the second api search result
+ # This test can fail spuriously for the same reasons that "Redirects count
as incoming links" can fail
Scenario: Results are sorted based on how close the match is
When I api search with disabled incoming link weighting for
Relevancyclosetest Foô
diff --git a/tests/browser/features/support/hooks.rb
b/tests/browser/features/support/hooks.rb
index 90317a3..d356506 100644
--- a/tests/browser/features/support/hooks.rb
+++ b/tests/browser/features/support/hooks.rb
@@ -494,12 +494,6 @@
And a page named Relevancylanguagetest/ja exists
And a page named Relevancylanguagetest/en exists
And a page named Relevancylanguagetest/ar exists
- And a page named Relevancylinktest Smaller exists
- And a page named Relevancylinktest Larger Extraword exists
- And a page named Relevancylinktest Larger/Link A exists with contents
[[Relevancylinktest Larger Extraword]]
- And a page named Relevancylinktest Larger/Link B exists with contents
[[Relevancylinktest Larger Extraword]]
- And a page named Relevancylinktest Larger/Link C exists with contents
[[Relevancylinktest Larger Extraword]]
- And a page named Relevancylinktest Larger/Link D exists with contents
[[Relevancylinktest Larger Extraword]]
And a page named Relevancyclosetest Foô exists
And a page named Relevancyclosetest Foo exists
And a page named Foo Relevancyclosetest exists
--
To view, visit https://gerrit.wikimedia.org/r/223359
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I12d0ad9ca9bbd8186d6d1db9fc903e49f87335dd
Gerrit-PatchSet: 3
Gerrit-Project: mediawiki/extensions/CirrusSearch
Gerrit-Branch: master
Gerrit-Owner: Manybubbles <[email protected]>
Gerrit-Reviewer: Chad <[email protected]>
Gerrit-Reviewer: Cindy-the-browser-test-bot <[email protected]>
Gerrit-Reviewer: DCausse <[email protected]>
Gerrit-Reviewer: EBernhardson <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
