Bartosz Dziewoński has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/232400

Change subject: mediawiki.api.upload: Use this.defaults.parameters instead of 
all-custom params
......................................................................

mediawiki.api.upload: Use this.defaults.parameters instead of all-custom params

Change-Id: I3326f30a52949bbe85aee9fcff39ca34002aab90
---
M resources/src/mediawiki.api/mediawiki.api.upload.js
1 file changed, 2 insertions(+), 8 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core 
refs/changes/00/232400/1

diff --git a/resources/src/mediawiki.api/mediawiki.api.upload.js 
b/resources/src/mediawiki.api/mediawiki.api.upload.js
index 9b29bbf..ed6c29e 100644
--- a/resources/src/mediawiki.api/mediawiki.api.upload.js
+++ b/resources/src/mediawiki.api/mediawiki.api.upload.js
@@ -164,13 +164,8 @@
                                iframe = getNewIframe( id ),
                                $iframe = $( iframe );
 
+                       data = $.extend( {}, this.defaults.parameters, { 
action: 'upload' }, data );
                        $form.addClass( 'mw-api-upload-form' );
-
-                       $form.append(
-                               getHiddenInput( 'action', 'upload' ),
-                               getHiddenInput( 'format', 'json' ),
-                               file
-                       );
 
                        $form.css( 'display', 'none' )
                                .attr( {
@@ -255,8 +250,7 @@
                                deferred = $.Deferred(),
                                filenameFound = false;
 
-                       formData.append( 'action', 'upload' );
-                       formData.append( 'format', 'json' );
+                       data = $.extend( {}, this.defaults.parameters, { 
action: 'upload' }, data );
 
                        $.each( data, function ( key, val ) {
                                if ( key === 'filename' ) {

-- 
To view, visit https://gerrit.wikimedia.org/r/232400
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I3326f30a52949bbe85aee9fcff39ca34002aab90
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Bartosz Dziewoński <[email protected]>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to