Thiemo Mättig (WMDE) has uploaded a new change for review.
https://gerrit.wikimedia.org/r/232482
Change subject: Fix unchecked loop in wikibase.special.itemByTitle
......................................................................
Fix unchecked loop in wikibase.special.itemByTitle
Change-Id: I8e0ef480d257a2d6f065e4c56670c3711cebe4a2
---
M repo/resources/wikibase.special/wikibase.special.itemByTitle.js
1 file changed, 10 insertions(+), 7 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Wikibase
refs/changes/82/232482/1
diff --git a/repo/resources/wikibase.special/wikibase.special.itemByTitle.js
b/repo/resources/wikibase.special/wikibase.special.itemByTitle.js
index 1e4259d..8291746 100644
--- a/repo/resources/wikibase.special/wikibase.special.itemByTitle.js
+++ b/repo/resources/wikibase.special/wikibase.special.itemByTitle.js
@@ -15,13 +15,16 @@
}
// this will build a drop-down for the language selection:
- var siteList = [];
- for( var siteId in wb.sites.getSites() ) {
- var site = wb.sites.getSite( siteId );
- siteList.push( {
- label: site.getName() + ' (' + site.getId() +
')',
- value: site.getName() + ' (' + site.getId() +
')'
- } );
+ var sites = wb.sites.getSites(),
+ siteList = [];
+ for( var siteId in sites ) {
+ if( sites.hasOwnProperty( siteId ) ) {
+ var siteName = sites[ siteId ].getName();
+ siteList.push( {
+ label: siteName + ' (' + siteId + ')',
+ value: siteName + ' (' + siteId + ')'
+ } );
+ }
}
$( '#wb-itembytitle-sitename' ).suggester( { source: siteList }
);
// Hackety hack hack...
--
To view, visit https://gerrit.wikimedia.org/r/232482
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I8e0ef480d257a2d6f065e4c56670c3711cebe4a2
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Thiemo Mättig (WMDE) <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
