Jforrester has uploaded a new change for review.
https://gerrit.wikimedia.org/r/232547
Change subject: build: Enable jscs rule 'requireDotNotation' and make pass
......................................................................
build: Enable jscs rule 'requireDotNotation' and make pass
Change-Id: I2586e6959c3bbc7e4204242fc65551747c0e25a9
---
M .jscsrc
M modules/ve-mw/dm/models/ve.dm.MWMediaResourceProvider.js
M modules/ve-mw/dm/models/ve.dm.MWTemplateSpecModel.js
3 files changed, 3 insertions(+), 4 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/VisualEditor
refs/changes/47/232547/1
diff --git a/.jscsrc b/.jscsrc
index 0552ba9..027f328 100644
--- a/.jscsrc
+++ b/.jscsrc
@@ -1,7 +1,6 @@
{
"preset": "wikimedia",
- "requireDotNotation": null,
"requireSpacesInsideBrackets": null,
"requireVarDeclFirst": null,
"jsDoc": null
diff --git a/modules/ve-mw/dm/models/ve.dm.MWMediaResourceProvider.js
b/modules/ve-mw/dm/models/ve.dm.MWMediaResourceProvider.js
index 0ec5e2e..9836865 100644
--- a/modules/ve-mw/dm/models/ve.dm.MWMediaResourceProvider.js
+++ b/modules/ve-mw/dm/models/ve.dm.MWMediaResourceProvider.js
@@ -166,9 +166,9 @@
return [];
}
- if ( data[ 'continue' ] ) {
+ if ( data.continue ) {
// Update the offset for next time
- provider.setOffset( data[ 'continue'
].gsroffset );
+ provider.setOffset( data.continue.gsroffset );
} else {
// This is the last available set of results.
Mark as depleted!
provider.toggleDepleted( true );
diff --git a/modules/ve-mw/dm/models/ve.dm.MWTemplateSpecModel.js
b/modules/ve-mw/dm/models/ve.dm.MWTemplateSpecModel.js
index d68fbba..012b1e6 100644
--- a/modules/ve-mw/dm/models/ve.dm.MWTemplateSpecModel.js
+++ b/modules/ve-mw/dm/models/ve.dm.MWTemplateSpecModel.js
@@ -208,7 +208,7 @@
* @returns {string} Default parameter value
*/
ve.dm.MWTemplateSpecModel.prototype.getParameterDefaultValue = function ( name
) {
- return this.params[name]['default'];
+ return this.params[name].default;
};
/**
--
To view, visit https://gerrit.wikimedia.org/r/232547
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I2586e6959c3bbc7e4204242fc65551747c0e25a9
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Jforrester <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
