Jforrester has uploaded a new change for review.
https://gerrit.wikimedia.org/r/232555
Change subject: build: Enable jscs jsDoc rules 'require*Types' and make pass
......................................................................
build: Enable jscs jsDoc rules 'require*Types' and make pass
Change-Id: I60c769f1cb028e4f4da7aeb04ed2383b689ddbc8
---
M .jscsrc
M modules/ve-mw/ui/dialogs/ve.ui.MWCitationDialog.js
2 files changed, 4 insertions(+), 2 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/VisualEditor
refs/changes/55/232555/1
diff --git a/.jscsrc b/.jscsrc
index 1bb59d4..1959eea 100644
--- a/.jscsrc
+++ b/.jscsrc
@@ -14,6 +14,8 @@
"checkParamNames": true,
"checkRedundantAccess": true,
"checkRedundantReturns": true,
- "requireNewlineAfterDescription": true
+ "requireNewlineAfterDescription": true,
+ "requireParamTypes": true,
+ "requireReturnTypes": true
}
}
diff --git a/modules/ve-mw/ui/dialogs/ve.ui.MWCitationDialog.js
b/modules/ve-mw/ui/dialogs/ve.ui.MWCitationDialog.js
index 83168bd..3a1277d 100644
--- a/modules/ve-mw/ui/dialogs/ve.ui.MWCitationDialog.js
+++ b/modules/ve-mw/ui/dialogs/ve.ui.MWCitationDialog.js
@@ -145,7 +145,7 @@
/**
* Works out whether there are any set parameters that aren't just placeholders
*
- * @return boolean
+ * @return {boolean}
*/
ve.ui.MWCitationDialog.prototype.hasUsefulParameter = function () {
var foundUseful = false;
--
To view, visit https://gerrit.wikimedia.org/r/232555
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I60c769f1cb028e4f4da7aeb04ed2383b689ddbc8
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Jforrester <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
