Jforrester has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/232553

Change subject: build: Enable jscs jsDoc rules 'checkRedundant*' and make pass
......................................................................

build: Enable jscs jsDoc rules 'checkRedundant*' and make pass

Change-Id: I36262ee1fe6116749586014fd30df3e00733fa6c
---
M .jscsrc
M modules/ve-mw/dm/models/ve.dm.MWTemplateModel.js
2 files changed, 2 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/VisualEditor 
refs/changes/53/232553/1

diff --git a/.jscsrc b/.jscsrc
index 0a38ab0..43fbbeb 100644
--- a/.jscsrc
+++ b/.jscsrc
@@ -11,6 +11,8 @@
                        }
                },
                "checkParamNames": true,
+               "checkRedundantAccess": true,
+               "checkRedundantReturns": true,
                "requireNewlineAfterDescription": true
        }
 }
diff --git a/modules/ve-mw/dm/models/ve.dm.MWTemplateModel.js 
b/modules/ve-mw/dm/models/ve.dm.MWTemplateModel.js
index 049e29f..8e440a3 100644
--- a/modules/ve-mw/dm/models/ve.dm.MWTemplateModel.js
+++ b/modules/ve-mw/dm/models/ve.dm.MWTemplateModel.js
@@ -316,8 +316,6 @@
 
 /**
  * Set original data, to be used as a base for serialization.
- *
- * @return {Object} Template data
  */
 ve.dm.MWTemplateModel.prototype.setOriginalData = function ( data ) {
        this.originalData = data;

-- 
To view, visit https://gerrit.wikimedia.org/r/232553
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I36262ee1fe6116749586014fd30df3e00733fa6c
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Jforrester <[email protected]>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to