BBlack has uploaded a new change for review.
https://gerrit.wikimedia.org/r/232638
Change subject: vcl_cookies: reduce text-vs-mobile cookie variance
......................................................................
vcl_cookies: reduce text-vs-mobile cookie variance
This gets rid of the "disable" Cookie allowance on mobile, as I
think it's outdated (I don't see it log samples). It also limits
the "optin" case down to "optin=", and adds the standard
exceptions for static resources and the resource loader.
Bug: T109286
Change-Id: I2a471f464bc6a9cd31438d111d137963911ad2ca
---
M templates/varnish/text-common.inc.vcl.erb
1 file changed, 4 insertions(+), 4 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/operations/puppet
refs/changes/38/232638/1
diff --git a/templates/varnish/text-common.inc.vcl.erb
b/templates/varnish/text-common.inc.vcl.erb
index 695e141..8fb2a9e 100644
--- a/templates/varnish/text-common.inc.vcl.erb
+++ b/templates/varnish/text-common.inc.vcl.erb
@@ -35,10 +35,10 @@
// most of this mechanism but have a different Cookie regex during
// the refactoring process...
sub evaluate_cookie_mobile {
- // note extra matches for disable/optin, and lack of static and
load.php exemptions...
- if (req.http.Cookie ~ "disable"
- || req.http.Cookie ~ "optin"
- || req.http.Cookie ~ "([sS]ession|Token)=") {
+ // note extra match for optin=foo
+ if (req.http.Cookie ~ "(optin|[sS]ession|Token)="
+ && req.url !~ "^/static/"
+ && req.url !~ "^/w/load\.php") {
set req.hash_ignore_busy = true;
} else {
call stash_cookie;
--
To view, visit https://gerrit.wikimedia.org/r/232638
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I2a471f464bc6a9cd31438d111d137963911ad2ca
Gerrit-PatchSet: 1
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: BBlack <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
