jenkins-bot has submitted this change and it was merged.
Change subject: Don't pass time metadata to EntityChange::setMetadata
......................................................................
Don't pass time metadata to EntityChange::setMetadata
This is totally ignored by the setMetadata method
so lets just not pass it to it in the first place
Change-Id: I405642c993327920a09777783b903acae1044c96
---
M lib/includes/changes/EntityChange.php
M lib/tests/phpunit/changes/TestChanges.php
2 files changed, 0 insertions(+), 2 deletions(-)
Approvals:
Thiemo Mättig (WMDE): Looks good to me, approved
jenkins-bot: Verified
diff --git a/lib/includes/changes/EntityChange.php
b/lib/includes/changes/EntityChange.php
index 5673e52..d3747e2 100644
--- a/lib/includes/changes/EntityChange.php
+++ b/lib/includes/changes/EntityChange.php
@@ -180,7 +180,6 @@
'page_id' => $rc->getAttribute( 'rc_cur_id' ),
'rev_id' => $rc->getAttribute( 'rc_this_oldid' ),
'parent_id' => $rc->getAttribute( 'rc_last_oldid' ),
- 'time' => $rc->getAttribute( 'rc_timestamp' ),
) );
}
diff --git a/lib/tests/phpunit/changes/TestChanges.php
b/lib/tests/phpunit/changes/TestChanges.php
index 9435a9f..2ac9183 100644
--- a/lib/tests/phpunit/changes/TestChanges.php
+++ b/lib/tests/phpunit/changes/TestChanges.php
@@ -201,7 +201,6 @@
'rev_id' => $rev,
'parent_id' => $rev -1,
'user_text' => 'Some User',
- 'time' => wfTimestamp( TS_MW ),
);
$change->setMetadata( $meta );
--
To view, visit https://gerrit.wikimedia.org/r/231571
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I405642c993327920a09777783b903acae1044c96
Gerrit-PatchSet: 3
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Addshore <[email protected]>
Gerrit-Reviewer: Aude <[email protected]>
Gerrit-Reviewer: Jonas Kress (WMDE) <[email protected]>
Gerrit-Reviewer: Thiemo Mättig (WMDE) <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
