Ricordisamoa has uploaded a new change for review.
https://gerrit.wikimedia.org/r/232698
Change subject: New parameters 'reverse' and 'sortbyvalue' for
Special:PagesWithProp
......................................................................
New parameters 'reverse' and 'sortbyvalue' for Special:PagesWithProp
Bug: T66950
Change-Id: Idc31289b1a9dd4746b2ecd502a23b182210384d8
---
M includes/specials/SpecialPagesWithProp.php
1 file changed, 13 insertions(+), 1 deletion(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core
refs/changes/98/232698/1
diff --git a/includes/specials/SpecialPagesWithProp.php
b/includes/specials/SpecialPagesWithProp.php
index 670a397..bed0af2 100644
--- a/includes/specials/SpecialPagesWithProp.php
+++ b/includes/specials/SpecialPagesWithProp.php
@@ -31,6 +31,8 @@
class SpecialPagesWithProp extends QueryPage {
private $propName = null;
private $existingPropNames = null;
+ private $reverse = false;
+ private $sortByValue = false;
function __construct( $name = 'PagesWithProp' ) {
parent::__construct( $name );
@@ -47,6 +49,8 @@
$request = $this->getRequest();
$propname = $request->getVal( 'propname', $par );
+ $this->reverse = $request->getBool( 'reverse' );
+ $this->sortByValue = $request->getBool( 'sortbyvalue' );
$propnames = $this->getExistingPropNames();
@@ -121,7 +125,15 @@
}
function getOrderFields() {
- return array( 'page_id' );
+ $sort = array( 'page_id' );
+ if ( $this->sortByValue ) {
+ array_unshift( $sort, 'pp_sortkey' );
+ }
+ return $sort;
+ }
+
+ public function sortDescending() {
+ return !$this->reverse;
}
/**
--
To view, visit https://gerrit.wikimedia.org/r/232698
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Idc31289b1a9dd4746b2ecd502a23b182210384d8
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Ricordisamoa <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
