jenkins-bot has submitted this change and it was merged.
Change subject: Sortable: Added RL dependency
......................................................................
Sortable: Added RL dependency
In current versions of MediaWiki the sortable functionality (e.g in
"Preferences") was broken.
This fix solves the issue.
Change-Id: I47107e1bd515a677c6ee559c30baade422122971
---
M resources/bluespice/bluespice.html.formfields.sortable.js
1 file changed, 11 insertions(+), 9 deletions(-)
Approvals:
Tweichart: Looks good to me, approved
jenkins-bot: Verified
diff --git a/resources/bluespice/bluespice.html.formfields.sortable.js
b/resources/bluespice/bluespice.html.formfields.sortable.js
index 05d2ce5..b701dbf 100644
--- a/resources/bluespice/bluespice.html.formfields.sortable.js
+++ b/resources/bluespice/bluespice.html.formfields.sortable.js
@@ -1,12 +1,14 @@
( function ( mw, bs, $, undefined ) {
- $( '.multiselectsortlist' ).sortable( {
- update: function( event, ui ) {
- $( this ).next().children().remove(); //Remove all
"option" tags from the hidden "select" element
- $( this ).children().each( function( index, element ) {
- $( this ).parent().next() //The "select" element
- .append( '<option selected="selected" value="'
+ $(this).attr( 'data-value' ) + '">' + $(this).html() + '</option>' );
- //We have to use .attr( 'data-value' ) instead
of .data('value' ) because of some jQuery version issues. Maybe correct this in
future versions.
- });
- }
+ mw.loader.using( 'jquery.ui.sortable' ).done(function() {
+ $( '.multiselectsortlist' ).sortable( {
+ update: function( event, ui ) {
+ $( this ).next().children().remove(); //Remove
all "option" tags from the hidden "select" element
+ $( this ).children().each( function( index,
element ) {
+ $( this ).parent().next() //The
"select" element
+ .append( '<option selected="selected"
value="' + $(this).attr( 'data-value' ) + '">' + $(this).html() + '</option>' );
+ //We have to use .attr( 'data-value' )
instead of .data('value' ) because of some jQuery version issues. Maybe correct
this in future versions.
+ });
+ }
+ });
});
}( mediaWiki, blueSpice, jQuery ) );
\ No newline at end of file
--
To view, visit https://gerrit.wikimedia.org/r/232247
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I47107e1bd515a677c6ee559c30baade422122971
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/BlueSpiceFoundation
Gerrit-Branch: master
Gerrit-Owner: Robert Vogel <[email protected]>
Gerrit-Reviewer: Mglaser <[email protected]>
Gerrit-Reviewer: Pwirth <[email protected]>
Gerrit-Reviewer: Tweichart <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
