Ricordisamoa has uploaded a new change for review.
https://gerrit.wikimedia.org/r/232718
Change subject: Add public keywords to QueryPage subclasses
......................................................................
Add public keywords to QueryPage subclasses
Follows a5c9c9607e034a00edc79146ec778e3d9c05e50a
Change-Id: I81b1d49e017792dea2c7eb0d98e99656576cf497
---
M includes/specials/SpecialAncientpages.php
M includes/specials/SpecialBrokenRedirects.php
M includes/specials/SpecialDoubleRedirects.php
M includes/specials/SpecialFewestrevisions.php
M includes/specials/SpecialFileDuplicateSearch.php
M includes/specials/SpecialLinkSearch.php
M includes/specials/SpecialListDuplicatedFiles.php
M includes/specials/SpecialListredirects.php
M includes/specials/SpecialMIMEsearch.php
M includes/specials/SpecialMediaStatistics.php
M includes/specials/SpecialMostcategories.php
M includes/specials/SpecialMostinterwikis.php
M includes/specials/SpecialMostlinked.php
M includes/specials/SpecialMostlinkedcategories.php
M includes/specials/SpecialPagesWithProp.php
M includes/specials/SpecialShortpages.php
M includes/specials/SpecialUnusedcategories.php
M includes/specials/SpecialUnusedtemplates.php
M includes/specials/SpecialUnwatchedpages.php
19 files changed, 37 insertions(+), 37 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core
refs/changes/18/232718/1
diff --git a/includes/specials/SpecialAncientpages.php
b/includes/specials/SpecialAncientpages.php
index b083032..2da24a8 100644
--- a/includes/specials/SpecialAncientpages.php
+++ b/includes/specials/SpecialAncientpages.php
@@ -32,7 +32,7 @@
parent::__construct( $name );
}
- function isExpensive() {
+ public function isExpensive() {
return true;
}
@@ -40,7 +40,7 @@
return false;
}
- function getQueryInfo() {
+ public function getQueryInfo() {
return array(
'tables' => array( 'page', 'revision' ),
'fields' => array(
@@ -56,7 +56,7 @@
);
}
- function usesTimestamps() {
+ public function usesTimestamps() {
return true;
}
diff --git a/includes/specials/SpecialBrokenRedirects.php
b/includes/specials/SpecialBrokenRedirects.php
index 1bbdbea..701f75f 100644
--- a/includes/specials/SpecialBrokenRedirects.php
+++ b/includes/specials/SpecialBrokenRedirects.php
@@ -32,7 +32,7 @@
parent::__construct( $name );
}
- function isExpensive() {
+ public function isExpensive() {
return true;
}
@@ -48,7 +48,7 @@
return $this->msg( 'brokenredirectstext' )->parseAsBlock();
}
- function getQueryInfo() {
+ public function getQueryInfo() {
$dbr = wfGetDB( DB_SLAVE );
return array(
diff --git a/includes/specials/SpecialDoubleRedirects.php
b/includes/specials/SpecialDoubleRedirects.php
index 47b426d..6d40985 100644
--- a/includes/specials/SpecialDoubleRedirects.php
+++ b/includes/specials/SpecialDoubleRedirects.php
@@ -32,7 +32,7 @@
parent::__construct( $name );
}
- function isExpensive() {
+ public function isExpensive() {
return true;
}
@@ -99,7 +99,7 @@
return $retval;
}
- function getQueryInfo() {
+ public function getQueryInfo() {
return $this->reallyGetQueryInfo();
}
diff --git a/includes/specials/SpecialFewestrevisions.php
b/includes/specials/SpecialFewestrevisions.php
index dc9d57c..406233b 100644
--- a/includes/specials/SpecialFewestrevisions.php
+++ b/includes/specials/SpecialFewestrevisions.php
@@ -32,7 +32,7 @@
parent::__construct( $name );
}
- function isExpensive() {
+ public function isExpensive() {
return true;
}
@@ -40,7 +40,7 @@
return false;
}
- function getQueryInfo() {
+ public function getQueryInfo() {
return array(
'tables' => array( 'revision', 'page' ),
'fields' => array(
diff --git a/includes/specials/SpecialFileDuplicateSearch.php
b/includes/specials/SpecialFileDuplicateSearch.php
index da79bb8..4c0c75f 100644
--- a/includes/specials/SpecialFileDuplicateSearch.php
+++ b/includes/specials/SpecialFileDuplicateSearch.php
@@ -48,7 +48,7 @@
return false;
}
- function isCached() {
+ public function isCached() {
return false;
}
@@ -82,7 +82,7 @@
$this->getOutput()->addHtml( implode( "\n", $html ) );
}
- function getQueryInfo() {
+ public function getQueryInfo() {
return array(
'tables' => array( 'image' ),
'fields' => array(
@@ -95,7 +95,7 @@
);
}
- function execute( $par ) {
+ public function execute( $par ) {
$this->setHeaders();
$this->outputHeader();
diff --git a/includes/specials/SpecialLinkSearch.php
b/includes/specials/SpecialLinkSearch.php
index 67683f2..dc882d4 100644
--- a/includes/specials/SpecialLinkSearch.php
+++ b/includes/specials/SpecialLinkSearch.php
@@ -80,7 +80,7 @@
return false;
}
- function execute( $par ) {
+ public function execute( $par ) {
$this->initServices();
$this->setHeaders();
@@ -218,7 +218,7 @@
return $params;
}
- function getQueryInfo() {
+ public function getQueryInfo() {
$dbr = wfGetDB( DB_SLAVE );
// strip everything past first wildcard, so that
// index-based-only lookup would be done
diff --git a/includes/specials/SpecialListDuplicatedFiles.php
b/includes/specials/SpecialListDuplicatedFiles.php
index 1e3dff6..317b62f 100644
--- a/includes/specials/SpecialListDuplicatedFiles.php
+++ b/includes/specials/SpecialListDuplicatedFiles.php
@@ -34,7 +34,7 @@
parent::__construct( $name );
}
- function isExpensive() {
+ public function isExpensive() {
return true;
}
@@ -53,7 +53,7 @@
* with however we are doing cached special pages.
* @return array
*/
- function getQueryInfo() {
+ public function getQueryInfo() {
return array(
'tables' => array( 'image' ),
'fields' => array(
diff --git a/includes/specials/SpecialListredirects.php
b/includes/specials/SpecialListredirects.php
index 2df4834..fa94b4a 100644
--- a/includes/specials/SpecialListredirects.php
+++ b/includes/specials/SpecialListredirects.php
@@ -33,7 +33,7 @@
parent::__construct( $name );
}
- function isExpensive() {
+ public function isExpensive() {
return true;
}
@@ -45,7 +45,7 @@
return false;
}
- function getQueryInfo() {
+ public function getQueryInfo() {
return array(
'tables' => array( 'p1' => 'page', 'redirect', 'p2' =>
'page' ),
'fields' => array( 'namespace' => 'p1.page_namespace',
diff --git a/includes/specials/SpecialMIMEsearch.php
b/includes/specials/SpecialMIMEsearch.php
index 64d4982..32344a8 100644
--- a/includes/specials/SpecialMIMEsearch.php
+++ b/includes/specials/SpecialMIMEsearch.php
@@ -34,7 +34,7 @@
parent::__construct( $name );
}
- function isExpensive() {
+ public function isExpensive() {
return true;
}
@@ -123,7 +123,7 @@
Xml::closeElement( 'form' );
}
- function execute( $par ) {
+ public function execute( $par ) {
$this->mime = $par ? $par : $this->getRequest()->getText(
'mime' );
$this->mime = trim( $this->mime );
list( $this->major, $this->minor ) = File::splitMime(
$this->mime );
diff --git a/includes/specials/SpecialMediaStatistics.php
b/includes/specials/SpecialMediaStatistics.php
index 7a7979c..e5ba8c6 100644
--- a/includes/specials/SpecialMediaStatistics.php
+++ b/includes/specials/SpecialMediaStatistics.php
@@ -36,7 +36,7 @@
$this->shownavigation = false;
}
- function isExpensive() {
+ public function isExpensive() {
return true;
}
diff --git a/includes/specials/SpecialMostcategories.php
b/includes/specials/SpecialMostcategories.php
index c70bbdb..18083f6 100644
--- a/includes/specials/SpecialMostcategories.php
+++ b/includes/specials/SpecialMostcategories.php
@@ -34,7 +34,7 @@
parent::__construct( $name );
}
- function isExpensive() {
+ public function isExpensive() {
return true;
}
@@ -42,7 +42,7 @@
return false;
}
- function getQueryInfo() {
+ public function getQueryInfo() {
return array(
'tables' => array( 'categorylinks', 'page' ),
'fields' => array(
diff --git a/includes/specials/SpecialMostinterwikis.php
b/includes/specials/SpecialMostinterwikis.php
index ab3d9c9..b07b833 100644
--- a/includes/specials/SpecialMostinterwikis.php
+++ b/includes/specials/SpecialMostinterwikis.php
@@ -34,7 +34,7 @@
parent::__construct( $name );
}
- function isExpensive() {
+ public function isExpensive() {
return true;
}
@@ -42,7 +42,7 @@
return false;
}
- function getQueryInfo() {
+ public function getQueryInfo() {
return array(
'tables' => array(
'langlinks',
diff --git a/includes/specials/SpecialMostlinked.php
b/includes/specials/SpecialMostlinked.php
index ae0b070..019df49 100644
--- a/includes/specials/SpecialMostlinked.php
+++ b/includes/specials/SpecialMostlinked.php
@@ -35,7 +35,7 @@
parent::__construct( $name );
}
- function isExpensive() {
+ public function isExpensive() {
return true;
}
@@ -43,7 +43,7 @@
return false;
}
- function getQueryInfo() {
+ public function getQueryInfo() {
return array(
'tables' => array( 'pagelinks', 'page' ),
'fields' => array(
diff --git a/includes/specials/SpecialMostlinkedcategories.php
b/includes/specials/SpecialMostlinkedcategories.php
index cc718e0..6eeab91 100644
--- a/includes/specials/SpecialMostlinkedcategories.php
+++ b/includes/specials/SpecialMostlinkedcategories.php
@@ -38,7 +38,7 @@
return false;
}
- function getQueryInfo() {
+ public function getQueryInfo() {
return array(
'tables' => array( 'category' ),
'fields' => array( 'title' => 'cat_title',
diff --git a/includes/specials/SpecialPagesWithProp.php
b/includes/specials/SpecialPagesWithProp.php
index 670a397..26d0fe8 100644
--- a/includes/specials/SpecialPagesWithProp.php
+++ b/includes/specials/SpecialPagesWithProp.php
@@ -40,7 +40,7 @@
return false;
}
- function execute( $par ) {
+ public function execute( $par ) {
$this->setHeaders();
$this->outputHeader();
$this->getOutput()->addModuleStyles(
'mediawiki.special.pagesWithProp' );
@@ -100,7 +100,7 @@
return false;
}
- function getQueryInfo() {
+ public function getQueryInfo() {
return array(
'tables' => array( 'page_props', 'page' ),
'fields' => array(
diff --git a/includes/specials/SpecialShortpages.php
b/includes/specials/SpecialShortpages.php
index 7ec69e0..ba11862 100644
--- a/includes/specials/SpecialShortpages.php
+++ b/includes/specials/SpecialShortpages.php
@@ -37,7 +37,7 @@
return false;
}
- function getQueryInfo() {
+ public function getQueryInfo() {
return array(
'tables' => array( 'page' ),
'fields' => array(
diff --git a/includes/specials/SpecialUnusedcategories.php
b/includes/specials/SpecialUnusedcategories.php
index 713823b..0d3216c 100644
--- a/includes/specials/SpecialUnusedcategories.php
+++ b/includes/specials/SpecialUnusedcategories.php
@@ -29,7 +29,7 @@
parent::__construct( $name );
}
- function isExpensive() {
+ public function isExpensive() {
return true;
}
@@ -37,7 +37,7 @@
return $this->msg( 'unusedcategoriestext' )->parseAsBlock();
}
- function getQueryInfo() {
+ public function getQueryInfo() {
return array(
'tables' => array( 'page', 'categorylinks' ),
'fields' => array(
diff --git a/includes/specials/SpecialUnusedtemplates.php
b/includes/specials/SpecialUnusedtemplates.php
index 0c2b870..33444f6 100644
--- a/includes/specials/SpecialUnusedtemplates.php
+++ b/includes/specials/SpecialUnusedtemplates.php
@@ -34,7 +34,7 @@
parent::__construct( $name );
}
- function isExpensive() {
+ public function isExpensive() {
return true;
}
@@ -46,7 +46,7 @@
return false;
}
- function getQueryInfo() {
+ public function getQueryInfo() {
return array(
'tables' => array( 'page', 'templatelinks' ),
'fields' => array(
diff --git a/includes/specials/SpecialUnwatchedpages.php
b/includes/specials/SpecialUnwatchedpages.php
index bb07c19..b3ca006 100644
--- a/includes/specials/SpecialUnwatchedpages.php
+++ b/includes/specials/SpecialUnwatchedpages.php
@@ -35,7 +35,7 @@
parent::__construct( $name, 'unwatchedpages' );
}
- function isExpensive() {
+ public function isExpensive() {
return true;
}
@@ -43,7 +43,7 @@
return false;
}
- function getQueryInfo() {
+ public function getQueryInfo() {
return array(
'tables' => array( 'page', 'watchlist' ),
'fields' => array(
--
To view, visit https://gerrit.wikimedia.org/r/232718
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I81b1d49e017792dea2c7eb0d98e99656576cf497
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Ricordisamoa <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
