Sumit has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/232759

Change subject: WikidataPageBanner move toc position
......................................................................

WikidataPageBanner move toc position

https://gerrit.wikimedia.org/r/#/c/228813/ hides the overflow on banner to
support cropping. As a side effect it also cropped overflowing TOC. Therefore
move the toc out of .wpb-topbanner and keep it within .ext-wpb-pagebanner.

Bug: T109628
Change-Id: I58b085496f2e84b8b157c43cad3932eac49a0d49
---
M resources/ext.WikidataPageBanner.styles/ext.WikidataPageBanner.less
M templates/banner.mustache
2 files changed, 2 insertions(+), 1 deletion(-)


  git pull 
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/WikidataPageBanner 
refs/changes/59/232759/1

diff --git 
a/resources/ext.WikidataPageBanner.styles/ext.WikidataPageBanner.less 
b/resources/ext.WikidataPageBanner.styles/ext.WikidataPageBanner.less
index fac010a..3e43e1b 100644
--- a/resources/ext.WikidataPageBanner.styles/ext.WikidataPageBanner.less
+++ b/resources/ext.WikidataPageBanner.styles/ext.WikidataPageBanner.less
@@ -10,6 +10,7 @@
 }
 
 .ext-wpb-pagebanner {
+       position: relative;
        width:100%;
 }
 
diff --git a/templates/banner.mustache b/templates/banner.mustache
index aca46f3..6331f94 100644
--- a/templates/banner.mustache
+++ b/templates/banner.mustache
@@ -9,6 +9,6 @@
                        {{/icons}}
                </div>
                {{/hasIcons}}
-               <div class="wpb-topbanner-toc 
{{#bottomtoc}}wpb-bottomtoc{{/bottomtoc}}"><div 
class="wpb-banner-toc">{{{toc}}}</div></div>
        </div>
+       <div class="wpb-topbanner-toc 
{{#bottomtoc}}wpb-bottomtoc{{/bottomtoc}}"><div 
class="wpb-banner-toc">{{{toc}}}</div></div>
 </div>

-- 
To view, visit https://gerrit.wikimedia.org/r/232759
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I58b085496f2e84b8b157c43cad3932eac49a0d49
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/WikidataPageBanner
Gerrit-Branch: master
Gerrit-Owner: Sumit <[email protected]>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to