Catrope has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/232778

Change subject: Use .moveCursorToEnd() instead of ve.selectEnd()
......................................................................

Use .moveCursorToEnd() instead of ve.selectEnd()

ve.selectEnd() removed by I44f43f312c78 in VE core.
Depends on Ia63e6c6a0 in OOjs UI.

Change-Id: Ic7ed8a24abd8288d68cf89839a553a569081e8c7
---
M modules/ve-mw/ui/dialogs/ve.ui.MWSaveDialog.js
1 file changed, 1 insertion(+), 2 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/VisualEditor 
refs/changes/78/232778/1

diff --git a/modules/ve-mw/ui/dialogs/ve.ui.MWSaveDialog.js 
b/modules/ve-mw/ui/dialogs/ve.ui.MWSaveDialog.js
index 13af0c6..112baba 100644
--- a/modules/ve-mw/ui/dialogs/ve.ui.MWSaveDialog.js
+++ b/modules/ve-mw/ui/dialogs/ve.ui.MWSaveDialog.js
@@ -174,8 +174,7 @@
                        this.actions.setMode( 'save' );
                        // HACK: FF needs *another* defer
                        setTimeout( function () {
-                               // FIXME we need to add features to 
OO.ui.TextInputWidget so we don't need to access .$input
-                               ve.selectEnd( dialog.editSummaryInput.$input[ 0 
] );
+                               dialog.editSummaryInput.moveCursorToEnd();
                        } );
                        break;
                case 'conflict':

-- 
To view, visit https://gerrit.wikimedia.org/r/232778
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic7ed8a24abd8288d68cf89839a553a569081e8c7
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Catrope <[email protected]>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to