Krinkle has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/232852

Change subject: Revert "Don't top-load CSS" (causes FOUC)
......................................................................

Revert "Don't top-load CSS" (causes FOUC)

This reverts commit 024d62be45f11f8ca3706887112726bcea914fb7.

Loading this in the bottom causes a flash of unstyled content
in Chrome on MediaWiki-namespace CSS/JS pages where the text is
first black un-bolded on a grey background and then re-arranges
with bolding in a few places (visually widening some pieces of
text and bumping them over). This is visually distracting and
somewhat confusing.

There are upcoming plans to collapse the stylesheet queue (and even
the dynamic load queue). Let's start with the ones that are actually
causing FOUCs like this one.

Impact should be minimal as it only affects pages where this
module is loaded.

Change-Id: Iaf1ce5e5b8cff56e987581a3dbe7f24460badde2
---
M extension.json
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull 
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/SyntaxHighlight_GeSHi 
refs/changes/52/232852/1

diff --git a/extension.json b/extension.json
index 0c7e1b4..ed0d936 100644
--- a/extension.json
+++ b/extension.json
@@ -32,7 +32,7 @@
        },
        "ResourceModules": {
                "ext.pygments": {
-                       "position": "bottom",
+                       "position": "top",
                        "targets": [
                                "desktop",
                                "mobile"

-- 
To view, visit https://gerrit.wikimedia.org/r/232852
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Iaf1ce5e5b8cff56e987581a3dbe7f24460badde2
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/SyntaxHighlight_GeSHi
Gerrit-Branch: master
Gerrit-Owner: Krinkle <[email protected]>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to