Tim Landscheidt has uploaded a new change for review.
https://gerrit.wikimedia.org/r/232886
Change subject: Tools: Puppetize missing intermediate directory
......................................................................
Tools: Puppetize missing intermediate directory
Currently on a submit host, crontabs are backed up to
/data/project/.system/crontabs/$fqdn, but the parent directory
/data/project/.system/crontabs is not puppetized. This change fixes
this.
On Tools, the directory currently has the setgid bit set:
| scfc@tools-submit:~$ ls -dl /data/project/.system/crontabs
| drwxrws--- 5 root tools.admin 4096 Jun 19 14:36 /data/project/.system/crontabs
| scfc@tools-submit:~$
This appears to have been an oversight and is fixed by this change as
well.
Change-Id: I66c1e60c0a52d7abbab1275b44f429c105634b27
---
M modules/toollabs/manifests/submit.pp
1 file changed, 6 insertions(+), 0 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/operations/puppet
refs/changes/86/232886/1
diff --git a/modules/toollabs/manifests/submit.pp
b/modules/toollabs/manifests/submit.pp
index 456c217..f2c6e07 100644
--- a/modules/toollabs/manifests/submit.pp
+++ b/modules/toollabs/manifests/submit.pp
@@ -74,6 +74,12 @@
}
# Backup crontabs! See https://phabricator.wikimedia.org/T95798
+ file { '/data/project/.system/crontabs':
+ ensure => directory,
+ owner => 'root',
+ group => 'tools.admin',
+ mode => '0770',
+ }
file { "/data/project/.system/crontabs/${::fqdn}":
ensure => directory,
source => '/var/spool/cron/crontabs',
--
To view, visit https://gerrit.wikimedia.org/r/232886
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I66c1e60c0a52d7abbab1275b44f429c105634b27
Gerrit-PatchSet: 1
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Tim Landscheidt <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits