Sumit has uploaded a new change for review.
https://gerrit.wikimedia.org/r/232934
Change subject: WikidataPageBanner replace div with h1 for heading
......................................................................
WikidataPageBanner replace div with h1 for heading
Bug: T109811
Change-Id: I938214e260659a3d37b79cc8ea215f363af866c6
---
M resources/ext.WikidataPageBanner.styles/ext.WikidataPageBanner.less
M templates/banner.mustache
2 files changed, 4 insertions(+), 2 deletions(-)
git pull
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/WikidataPageBanner
refs/changes/34/232934/1
diff --git
a/resources/ext.WikidataPageBanner.styles/ext.WikidataPageBanner.less
b/resources/ext.WikidataPageBanner.styles/ext.WikidataPageBanner.less
index e104bfe..fb0b3d5 100644
--- a/resources/ext.WikidataPageBanner.styles/ext.WikidataPageBanner.less
+++ b/resources/ext.WikidataPageBanner.styles/ext.WikidataPageBanner.less
@@ -28,7 +28,9 @@
.wpb-topbanner .wpb-name {
position: absolute;
z-index: 2;
- margin: 0.6em 0 0 0.4em;
+ // skins's have their own margins on h1 however arbitrary margin on
banner h1 could cause a bad
+ // view, therefore rule made important
+ margin: 0.6em 0 0 0.4em !important;
padding: 8px 7px;
font-size: 2.2em;
font-weight: bold;
diff --git a/templates/banner.mustache b/templates/banner.mustache
index 6331f94..875e0cc 100644
--- a/templates/banner.mustache
+++ b/templates/banner.mustache
@@ -1,6 +1,6 @@
<div class="ext-wpb-pagebanner noprint">
<div class="wpb-topbanner">
- <div class="wpb-name">{{title}}</div>
+ <h1 class="wpb-name">{{title}}</h1>
<a class="image" title="{{tooltip}}" href="{{bannerfile}}"><img
src="{{banner}}" srcset="{{srcset}}" class="wpb-banner-image {{originx}}"
data-pos-x="{{data-pos-x}}" data-pos-y="{{data-pos-y}}"
style="max-width:{{maxWidth}}px"></a>
{{#hasIcons}}
<div class="wpb-iconbox">
--
To view, visit https://gerrit.wikimedia.org/r/232934
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I938214e260659a3d37b79cc8ea215f363af866c6
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/WikidataPageBanner
Gerrit-Branch: master
Gerrit-Owner: Sumit <asthana.sumi...@gmail.com>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
