Esanders has uploaded a new change for review.
https://gerrit.wikimedia.org/r/232953
Change subject: Factor our surface config compilation
......................................................................
Factor our surface config compilation
Change-Id: If187a573ea6684d19b8c5a8a915f6cc3abc567f8
---
M src/init/sa/ve.init.sa.MobileTarget.js
M src/init/ve.init.Target.js
2 files changed, 12 insertions(+), 12 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/VisualEditor/VisualEditor
refs/changes/53/232953/1
diff --git a/src/init/sa/ve.init.sa.MobileTarget.js
b/src/init/sa/ve.init.sa.MobileTarget.js
index ff891b6..975d962 100644
--- a/src/init/sa/ve.init.sa.MobileTarget.js
+++ b/src/init/sa/ve.init.sa.MobileTarget.js
@@ -86,16 +86,7 @@
* @inheritdoc
*/
ve.init.sa.MobileTarget.prototype.createSurface = function ( dmDoc, config ) {
- config = ve.extendObject( {
- includeCommands: this.constructor.static.includeCommands,
- excludeCommands: OO.simpleArrayUnion(
- this.constructor.static.excludeCommands,
- this.constructor.static.documentCommands,
- this.constructor.static.targetCommands
- ),
- importRules: this.constructor.static.importRules
- }, config );
- return new ve.ui.MobileSurface( dmDoc, config );
+ return new ve.ui.MobileSurface( dmDoc, this.getSurfaceConfig( config )
);
};
/**
diff --git a/src/init/ve.init.Target.js b/src/init/ve.init.Target.js
index a7eb27f..0b64543 100644
--- a/src/init/ve.init.Target.js
+++ b/src/init/ve.init.Target.js
@@ -286,7 +286,17 @@
* @return {ve.ui.Surface}
*/
ve.init.Target.prototype.createSurface = function ( dmDoc, config ) {
- config = ve.extendObject( {
+ return new ve.ui.DesktopSurface( dmDoc, this.getSurfaceConfig( config )
);
+};
+
+/**
+ * Get surface configuration options
+ *
+ * @param {Object} config Configuration option overrides
+ * @return {Object} Surface configuration options
+ */
+ve.init.Target.prototype.getSurfaceConfig = function ( config ) {
+ return ve.extendObject( {
includeCommands: this.constructor.static.includeCommands,
excludeCommands: OO.simpleArrayUnion(
this.constructor.static.excludeCommands,
@@ -295,7 +305,6 @@
),
importRules: this.constructor.static.importRules
}, config );
- return new ve.ui.DesktopSurface( dmDoc, config );
};
/**
--
To view, visit https://gerrit.wikimedia.org/r/232953
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: If187a573ea6684d19b8c5a8a915f6cc3abc567f8
Gerrit-PatchSet: 1
Gerrit-Project: VisualEditor/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Esanders <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
