jenkins-bot has submitted this change and it was merged.
Change subject: Append specific message to generic communication error
......................................................................
Append specific message to generic communication error
This is something the orphan slayer does pretty regularly, perhaps cos
orphans can fail validation performed inside other functions. The error
message actually is bubbled up, so grab that and log it.
Bug: T109527
Change-Id: Ib2772605aaf030cc7ee698d6003539cb20f6102c
---
M globalcollect_gateway/globalcollect.adapter.php
1 file changed, 2 insertions(+), 1 deletion(-)
Approvals:
XenoRyet: Looks good to me, approved
jenkins-bot: Verified
diff --git a/globalcollect_gateway/globalcollect.adapter.php
b/globalcollect_gateway/globalcollect.adapter.php
index 75085df..2cffd48 100644
--- a/globalcollect_gateway/globalcollect.adapter.php
+++ b/globalcollect_gateway/globalcollect.adapter.php
@@ -1286,7 +1286,8 @@
} elseif ( $status_result->getCommunicationStatus() ===
false ) {
//can't communicate or internal error
$problemflag = true;
- $problemmessage = "Can't communicate or
internal error."; // /me shrugs - I think the orphan slayer is hitting this
sometimes. Confusing.
+ $problemmessage = "Can't communicate or
internal error: "
+ . $status_result->getMessage();
}
$order_status_results = false;
--
To view, visit https://gerrit.wikimedia.org/r/232908
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib2772605aaf030cc7ee698d6003539cb20f6102c
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/DonationInterface
Gerrit-Branch: master
Gerrit-Owner: Awight <[email protected]>
Gerrit-Reviewer: AndyRussG <[email protected]>
Gerrit-Reviewer: Ejegg <[email protected]>
Gerrit-Reviewer: Ssmith <[email protected]>
Gerrit-Reviewer: XenoRyet <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
