jenkins-bot has submitted this change and it was merged.
Change subject: Fix addMissingLoggingEntries maintenance script handling of
newlines
......................................................................
Fix addMissingLoggingEntries maintenance script handling of newlines
Bug: T54919
Change-Id: I0a979d9022ce3371813e214a7e4e1432e34c823b
---
M maintenance/addMissingLoggingEntries.php
1 file changed, 2 insertions(+), 2 deletions(-)
Approvals:
Aaron Schulz: Looks good to me, approved
jenkins-bot: Verified
diff --git a/maintenance/addMissingLoggingEntries.php
b/maintenance/addMissingLoggingEntries.php
index 56603fd..1c9776b 100644
--- a/maintenance/addMissingLoggingEntries.php
+++ b/maintenance/addMissingLoggingEntries.php
@@ -25,7 +25,7 @@
// Because the timestamp matches aren't exact (sometimes a
couple of seconds off), we need to check all our results and ignore those that
do actually have log entries
foreach ( $afhResult as $row ) {
- $logParams[] = $row->afh_id . '\n' . $row->afh_filter;
+ $logParams[] = $row->afh_id . "\n" . $row->afh_filter;
$afhRows[$row->afh_id] = $row;
}
@@ -41,7 +41,7 @@
);
foreach ( $logResult as $row ) {
- $params = explode( "\\n", $row->log_params ); // id .
'\n' . filter
+ $params = explode( "\n", $row->log_params ); // id .
'\n' . filter
$afhId = $params[0]; // id
unset( $afhRows[$afhId] ); // Forget this row had any
issues - it just has a different timestamp in the log
}
--
To view, visit https://gerrit.wikimedia.org/r/233174
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I0a979d9022ce3371813e214a7e4e1432e34c823b
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/AbuseFilter
Gerrit-Branch: master
Gerrit-Owner: Alex Monk <[email protected]>
Gerrit-Reviewer: Aaron Schulz <[email protected]>
Gerrit-Reviewer: Jackmcbarn <[email protected]>
Gerrit-Reviewer: Legoktm <[email protected]>
Gerrit-Reviewer: Se4598 <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
