Esanders has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/233217

Change subject: Remove space inserted after URL paste
......................................................................

Remove space inserted after URL paste

This is inconsistent with other paste behaviour, and also spaces
are language specific (e.g. Chinese would have no spaces or full
width spaces).

Change-Id: I54d47e4e6146d58746fc4be1964f2593032ba22b
---
M src/ui/datatransferhandlers/ve.ui.UrlStringTransferHandler.js
M tests/ui/datatransferhandlers/ve.ui.UrlStringTransferHandler.test.js
2 files changed, 4 insertions(+), 9 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/VisualEditor/VisualEditor 
refs/changes/17/233217/1

diff --git a/src/ui/datatransferhandlers/ve.ui.UrlStringTransferHandler.js 
b/src/ui/datatransferhandlers/ve.ui.UrlStringTransferHandler.js
index 3e36303..c35c1a3 100644
--- a/src/ui/datatransferhandlers/ve.ui.UrlStringTransferHandler.js
+++ b/src/ui/datatransferhandlers/ve.ui.UrlStringTransferHandler.js
@@ -140,7 +140,6 @@
                for ( i = 0; i < content.length; i++ ) {
                        result.push( content[ i ] );
                }
-               result.push( ' ' );
        } );
        this.resolve( result );
 };
diff --git 
a/tests/ui/datatransferhandlers/ve.ui.UrlStringTransferHandler.test.js 
b/tests/ui/datatransferhandlers/ve.ui.UrlStringTransferHandler.test.js
index 7ed2cd8..80aeafc 100644
--- a/tests/ui/datatransferhandlers/ve.ui.UrlStringTransferHandler.test.js
+++ b/tests/ui/datatransferhandlers/ve.ui.UrlStringTransferHandler.test.js
@@ -64,8 +64,7 @@
                                                [ '.', [ a ] ],
                                                [ 'c', [ a ] ],
                                                [ 'o', [ a ] ],
-                                               [ 'm', [ a ] ],
-                                               ' '
+                                               [ 'm', [ a ] ]
                                        ];
                                }
                        },
@@ -93,8 +92,7 @@
                                                [ '.', [ a ] ],
                                                [ 'c', [ a ] ],
                                                [ 'o', [ a ] ],
-                                               [ 'm', [ a ] ],
-                                               ' '
+                                               [ 'm', [ a ] ]
                                        ];
                                }
                        },
@@ -108,8 +106,7 @@
                                        return [
                                                [ 'F', [ a ] ],
                                                [ 'o', [ a ] ],
-                                               [ 'o', [ a ] ],
-                                               ' '
+                                               [ 'o', [ a ] ]
                                        ];
                                }
                        },
@@ -126,8 +123,7 @@
                                                [ 'o', [ a ] ],
                                                [ 'o', [ a ] ],
                                                [ ']', [ a ] ],
-                                               [ ']', [ a ] ],
-                                               ' '
+                                               [ ']', [ a ] ]
                                        ];
                                }
                        }

-- 
To view, visit https://gerrit.wikimedia.org/r/233217
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I54d47e4e6146d58746fc4be1964f2593032ba22b
Gerrit-PatchSet: 1
Gerrit-Project: VisualEditor/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Esanders <[email protected]>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to