jenkins-bot has submitted this change and it was merged.
Change subject: Add colour to neutral state of MW frameless buttons
......................................................................
Add colour to neutral state of MW frameless buttons
Buttons should indicate their meaning without hover
for mobile users.
Bug: T108086
Change-Id: I0267419abcbe2cae8ef7df652d1379362ada90c2
---
M src/themes/mediawiki/elements.less
1 file changed, 6 insertions(+), 6 deletions(-)
Approvals:
Bartosz Dziewoński: Looks good to me, but someone else must approve
Jforrester: Looks good to me, approved
jenkins-bot: Verified
diff --git a/src/themes/mediawiki/elements.less
b/src/themes/mediawiki/elements.less
index 817eb6c..3c77899 100644
--- a/src/themes/mediawiki/elements.less
+++ b/src/themes/mediawiki/elements.less
@@ -70,15 +70,15 @@
&.oo-ui-flaggedElement {
&-progressive {
-
.mediawiki-frameless-button-colored(@progressive, @progressive-selected);
+
.mediawiki-frameless-button-colored(@progressive, @progressive-hover,
@progressive-selected);
}
&-constructive {
-
.mediawiki-frameless-button-colored(@constructive, @constructive-selected);
+
.mediawiki-frameless-button-colored(@constructive, @constructive-hover,
@constructive-selected);
}
&-destructive {
-
.mediawiki-frameless-button-colored(@destructive, @destructive-selected);
+
.mediawiki-frameless-button-colored(@destructive, @destructive-hover,
@destructive-selected);
}
}
}
@@ -205,17 +205,17 @@
}
}
-.mediawiki-frameless-button-colored( @neutral, @pressed ) {
+.mediawiki-frameless-button-colored( @neutral, @hover, @pressed ) {
> .oo-ui-buttonElement-button {
&:hover,
&:focus {
> .oo-ui-labelElement-label {
- color: @neutral;
+ color: @hover;
}
}
> .oo-ui-labelElement-label {
- color: #777777;
+ color: @neutral;
}
}
--
To view, visit https://gerrit.wikimedia.org/r/230056
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I0267419abcbe2cae8ef7df652d1379362ada90c2
Gerrit-PatchSet: 1
Gerrit-Project: oojs/ui
Gerrit-Branch: master
Gerrit-Owner: Esanders <[email protected]>
Gerrit-Reviewer: Bartosz Dziewoński <[email protected]>
Gerrit-Reviewer: Esanders <[email protected]>
Gerrit-Reviewer: Jforrester <[email protected]>
Gerrit-Reviewer: Nirzar <[email protected]>
Gerrit-Reviewer: Pginer <[email protected]>
Gerrit-Reviewer: Prtksxna <[email protected]>
Gerrit-Reviewer: Trevor Parscal <[email protected]>
Gerrit-Reviewer: VolkerE <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
