jenkins-bot has submitted this change and it was merged.
Change subject: Add spacer above basic reference option
......................................................................
Add spacer above basic reference option
Also add classes to basic/reuse so they can be differently styled.
Bug: T108725
Change-Id: I4d128afe86c7fae2d8cbd8a57749970942e39e76
---
M VisualEditor.hooks.php
A modules/ve-mw/ui/styles/widgets/ve.ui.MWReferenceSourceSelectWidget.css
M modules/ve-mw/ui/widgets/ve.ui.MWReferenceSourceSelectWidget.js
3 files changed, 19 insertions(+), 2 deletions(-)
Approvals:
Jforrester: Looks good to me, approved
jenkins-bot: Verified
diff --git a/VisualEditor.hooks.php b/VisualEditor.hooks.php
index 1a79507..a2536ea 100644
--- a/VisualEditor.hooks.php
+++ b/VisualEditor.hooks.php
@@ -495,6 +495,7 @@
'modules/ve-mw/ui/styles/widgets/ve.ui.MWReferenceGroupInputWidget.css',
'modules/ve-mw/ui/styles/widgets/ve.ui.MWReferenceResultWidget.css',
'modules/ve-mw/ui/styles/widgets/ve.ui.MWReferenceSearchWidget.css',
+
'modules/ve-mw/ui/styles/widgets/ve.ui.MWReferenceSourceSelectWidget.css',
),
'dependencies' => array(
'ext.visualEditor.mwreference.core',
diff --git
a/modules/ve-mw/ui/styles/widgets/ve.ui.MWReferenceSourceSelectWidget.css
b/modules/ve-mw/ui/styles/widgets/ve.ui.MWReferenceSourceSelectWidget.css
new file mode 100644
index 0000000..4beaa18
--- /dev/null
+++ b/modules/ve-mw/ui/styles/widgets/ve.ui.MWReferenceSourceSelectWidget.css
@@ -0,0 +1,10 @@
+/*!
+ * VisualEditor MediaWiki UserInterface MWReferenceSearchWidget styles.
+ *
+ * @copyright 2011-2015 VisualEditor Team and others; see AUTHORS.txt
+ * @license The MIT License (MIT); see LICENSE.txt
+ */
+
+.ve-ui-mwReferenceSourceSelectWidget-separator {
+ border-top: 1px solid #ccc;
+}
diff --git a/modules/ve-mw/ui/widgets/ve.ui.MWReferenceSourceSelectWidget.js
b/modules/ve-mw/ui/widgets/ve.ui.MWReferenceSourceSelectWidget.js
index fdf9bf6..a615211 100644
--- a/modules/ve-mw/ui/widgets/ve.ui.MWReferenceSourceSelectWidget.js
+++ b/modules/ve-mw/ui/widgets/ve.ui.MWReferenceSourceSelectWidget.js
@@ -50,7 +50,8 @@
this.refBasic = new OO.ui.DecoratedOptionWidget( {
icon: 'reference',
label: ve.msg( 'visualeditor-dialogbutton-reference-full-label'
),
- data: { windowName: 'reference' }
+ data: { windowName: 'reference' },
+ classes: [ 've-ui-mwReferenceSourceSelectWidget-basic' ]
} );
items.push( this.refBasic );
@@ -61,13 +62,18 @@
data: {
windowName: 'reference',
dialogData: { useExisting: true }
- }
+ },
+ classes: [ 've-ui-mwReferenceSourceSelectWidget-reuse' ]
} );
items.push( this.refExisting );
}
this.addItems( items );
+ $( '<div>' )
+ .addClass( 've-ui-mwReferenceSourceSelectWidget-separator' )
+ .insertBefore( this.refBasic.$element );
+
// Initialization
this.$element.addClass( 've-ui-mwReferenceSourceSelectWidget' );
};
--
To view, visit https://gerrit.wikimedia.org/r/233225
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I4d128afe86c7fae2d8cbd8a57749970942e39e76
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Esanders <[email protected]>
Gerrit-Reviewer: Jforrester <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
