Thiemo Mättig (WMDE) has uploaded a new change for review.
https://gerrit.wikimedia.org/r/233354
Change subject: Add array type hints to NotEntityIdValidator
......................................................................
Add array type hints to NotEntityIdValidator
Change-Id: Ia4c1d85eb694841bb542a07acaeedd5db3b172b1
---
M repo/includes/Validators/NotEntityIdValidator.php
1 file changed, 1 insertion(+), 5 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Wikibase
refs/changes/54/233354/1
diff --git a/repo/includes/Validators/NotEntityIdValidator.php
b/repo/includes/Validators/NotEntityIdValidator.php
index 029d9b2..6563b4e 100644
--- a/repo/includes/Validators/NotEntityIdValidator.php
+++ b/repo/includes/Validators/NotEntityIdValidator.php
@@ -41,11 +41,7 @@
*
* @throws InvalidArgumentException
*/
- public function __construct( EntityIdParser $idParser, $errorCode,
$forbiddenTypes = null ) {
- if ( !is_null( $forbiddenTypes ) && !is_array( $forbiddenTypes
) ) {
- throw new InvalidArgumentException( '$forbiddenTypes
must be an array' );
- }
-
+ public function __construct( EntityIdParser $idParser, $errorCode,
array $forbiddenTypes = null ) {
if ( !is_string( $errorCode ) ) {
throw new InvalidArgumentException( '$errorCode must be
a string' );
}
--
To view, visit https://gerrit.wikimedia.org/r/233354
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia4c1d85eb694841bb542a07acaeedd5db3b172b1
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Thiemo Mättig (WMDE) <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
