[MediaWiki-commits] [Gerrit] Private by default in ClaimHtmlGenerator - change (mediawiki...Wikibase)

[WMDE]

Thiemo Mättig (WMDE) has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/233357

Change subject: Private by default in ClaimHtmlGenerator
......................................................................

Private by default in ClaimHtmlGenerator

Change-Id: I62eb33959d6d8a19820b0a90cfa4784884f0f90d
---
M view/src/ClaimHtmlGenerator.php
1 file changed, 11 insertions(+), 11 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Wikibase 
refs/changes/57/233357/1

diff --git a/view/src/ClaimHtmlGenerator.php b/view/src/ClaimHtmlGenerator.php
index 887e769..40f1608 100644
--- a/view/src/ClaimHtmlGenerator.php
+++ b/view/src/ClaimHtmlGenerator.php
@@ -66,7 +66,7 @@
         * @param Statement $statement
         * @param null|string $editSectionHtml has the html for the edit section
         *
-        * @return string
+        * @return string HTML
         */
        public function getHtmlForClaim( Statement $statement, $editSectionHtml 
= null ) {
                $mainSnakHtml = $this->snakHtmlGenerator->getSnakHtml(
@@ -109,9 +109,9 @@
         *
         * @param SnakList $qualifiers
         *
-        * @return string
+        * @return string HTML
         */
-       protected function getHtmlForQualifiers( SnakList $qualifiers ) {
+       private function getHtmlForQualifiers( SnakList $qualifiers ) {
                $qualifiersByProperty = new ByPropertyIdGrouper( $qualifiers );
 
                $snaklistviewsHtml = '';
@@ -130,9 +130,9 @@
         *
         * @param ReferenceList $referenceList
         *
-        * @return string
+        * @return string HTML
         */
-       protected function getHtmlForReferences( ReferenceList $referenceList ) 
{
+       private function getHtmlForReferences( ReferenceList $referenceList ) {
                $referencesHtml = '';
 
                foreach ( $referenceList as $reference ) {
@@ -155,9 +155,9 @@
         *
         * @param Reference $reference
         *
-        * @return string
+        * @return string HTML
         */
-       protected function getHtmlForReference( $reference ) {
+       private function getHtmlForReference( Reference $reference ) {
                $snaks = $reference->getSnaks();
 
                $referenceSnaksByProperty = new ByPropertyIdGrouper( $snaks );
@@ -182,9 +182,9 @@
         *
         * @param Snak[] $snaks
         *
-        * @return string
+        * @return string HTML
         */
-       protected function getSnaklistviewHtml( $snaks ) {
+       private function getSnaklistviewHtml( array $snaks ) {
                $snaksHtml = '';
                $i = 0;
 
@@ -198,7 +198,7 @@
        /**
         * @param Statement $statement
         *
-        * @return string
+        * @return string HTML
         */
        private function getReferencesHeading( Statement $statement ) {
                $referenceCount = count( $statement->getReferences() );
@@ -218,7 +218,7 @@
        /**
         * @param string $serializedRank
         *
-        * @return string
+        * @return string Text
         */
        private function getStatementRankText( $serializedRank ) {
                if ( !array_key_exists( $serializedRank, 
$this->statementRankText ) ) {

-- 
To view, visit https://gerrit.wikimedia.org/r/233357
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I62eb33959d6d8a19820b0a90cfa4784884f0f90d
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Thiemo Mättig (WMDE) <thiemo.maet...@wikimedia.de>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits