jenkins-bot has submitted this change and it was merged.
Change subject: Add array type hints to GetEntities
......................................................................
Add array type hints to GetEntities
Change-Id: I4e177b703c48b0ccbf6619f6adaf56e2007d0383
---
M repo/includes/api/GetEntities.php
1 file changed, 4 insertions(+), 4 deletions(-)
Approvals:
Addshore: Looks good to me, approved
jenkins-bot: Verified
diff --git a/repo/includes/api/GetEntities.php
b/repo/includes/api/GetEntities.php
index 78ebe4c..6c7b244 100644
--- a/repo/includes/api/GetEntities.php
+++ b/repo/includes/api/GetEntities.php
@@ -170,7 +170,7 @@
* @param array $params
* @return EntityId[]
*/
- private function getItemIdsFromSiteTitleParams( $params ) {
+ private function getItemIdsFromSiteTitleParams( array $params ) {
$ids = array();
if ( !empty( $params['sites'] ) && !empty( $params['titles'] )
) {
$itemByTitleHelper = $this->getItemByTitleHelper();
@@ -195,9 +195,9 @@
}
/**
- * @param array $missingItems Array of arrays, Each internal array has
a key 'site' and 'title'
+ * @param array[] $missingItems Array of arrays, Each internal array
has a key 'site' and 'title'
*/
- private function addMissingItemsToResult( $missingItems ) {
+ private function addMissingItemsToResult( array $missingItems ) {
foreach ( $missingItems as $missingItem ) {
$this->resultBuilder->addMissingEntity( null,
$missingItem );
}
@@ -294,7 +294,7 @@
* 0 => string[] languageCodes that the user wants returned
* 1 => LanguageFallbackChain[] Keys are requested lang codes
*/
- private function getLanguageCodesAndFallback( $params ) {
+ private function getLanguageCodesAndFallback( array $params ) {
$languageCodes = ( is_array( $params['languages'] )?
$params['languages'] : array() );
$fallbackChains = array();
--
To view, visit https://gerrit.wikimedia.org/r/233355
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I4e177b703c48b0ccbf6619f6adaf56e2007d0383
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Thiemo Mättig (WMDE) <[email protected]>
Gerrit-Reviewer: Addshore <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
