jenkins-bot has submitted this change and it was merged.

Change subject: Fix "wikibase.special.itemByTitle"
......................................................................


Fix "wikibase.special.itemByTitle"

Adopt to "new" suggester data format, disable
autocompletion.

Bug: T68744
Change-Id: I9e6c7c4e12a97d7960cb7fabce5f39f1318eb83d
---
M repo/resources/wikibase.special/wikibase.special.itemByTitle.js
1 file changed, 4 insertions(+), 5 deletions(-)

Approvals:
  Thiemo Mättig (WMDE): Looks good to me, approved
  jenkins-bot: Verified



diff --git a/repo/resources/wikibase.special/wikibase.special.itemByTitle.js 
b/repo/resources/wikibase.special/wikibase.special.itemByTitle.js
index 1e4259d..3801368 100644
--- a/repo/resources/wikibase.special/wikibase.special.itemByTitle.js
+++ b/repo/resources/wikibase.special/wikibase.special.itemByTitle.js
@@ -18,12 +18,11 @@
                var siteList = [];
                for( var siteId in wb.sites.getSites() ) {
                        var site = wb.sites.getSite( siteId );
-                       siteList.push( {
-                               label: site.getName() + ' (' + site.getId() + 
')',
-                               value: site.getName() + ' (' + site.getId() + 
')'
-                       } );
+                       siteList.push( site.getName() + ' (' + site.getId() + 
')' );
                }
-               $( '#wb-itembytitle-sitename' ).suggester( { source: siteList } 
);
+               $( '#wb-itembytitle-sitename' )
+               .attr( 'autocomplete', 'off' )
+               .suggester( { source: siteList } );
                // Hackety hack hack...
                // On submit, replace human readable value like "English (en)" 
with actual sitename ("enwiki")
                $( '#wb-itembytitle-form1' ).submit( function() {

-- 
To view, visit https://gerrit.wikimedia.org/r/233195
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I9e6c7c4e12a97d7960cb7fabce5f39f1318eb83d
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Ricordisamoa <[email protected]>
Gerrit-Reviewer: Addshore <[email protected]>
Gerrit-Reviewer: Hoo man <[email protected]>
Gerrit-Reviewer: Jonas Kress (WMDE) <[email protected]>
Gerrit-Reviewer: Thiemo Mättig (WMDE) <[email protected]>
Gerrit-Reviewer: jenkins-bot <>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to