jenkins-bot has submitted this change and it was merged. Change subject: QA: Assert that diff page has fully loaded at end of click diff link step ......................................................................
QA: Assert that diff page has fully loaded at end of click diff link step Change-Id: If4e38ba91ba4bfc3165ccbbb238999ea53e8bc79 --- M tests/browser/features/step_definitions/special_history_steps.rb A tests/browser/features/support/pages/special_mobilediff_page.rb 2 files changed, 6 insertions(+), 0 deletions(-) Approvals: Bmansurov: Looks good to me, approved jenkins-bot: Verified diff --git a/tests/browser/features/step_definitions/special_history_steps.rb b/tests/browser/features/step_definitions/special_history_steps.rb index bf0c5b1..21697b9 100644 --- a/tests/browser/features/step_definitions/special_history_steps.rb +++ b/tests/browser/features/step_definitions/special_history_steps.rb @@ -4,6 +4,7 @@ When(/^I open the latest diff$/) do on(SpecialHistoryPage).last_contribution_link_element.click + expect(on(SpecialMobileDiffPage).user_info_element.when_present(20)).to be_visible end Then(/^I should see a more button$/) do diff --git a/tests/browser/features/support/pages/special_mobilediff_page.rb b/tests/browser/features/support/pages/special_mobilediff_page.rb new file mode 100644 index 0000000..601da18 --- /dev/null +++ b/tests/browser/features/support/pages/special_mobilediff_page.rb @@ -0,0 +1,5 @@ +class SpecialMobileDiffPage < ArticlePage + include PageObject + + div(:user_info, id: 'mw-mf-userinfo') +end -- To view, visit https://gerrit.wikimedia.org/r/232956 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: If4e38ba91ba4bfc3165ccbbb238999ea53e8bc79 Gerrit-PatchSet: 3 Gerrit-Project: mediawiki/extensions/MobileFrontend Gerrit-Branch: master Gerrit-Owner: Jdlrobson <[email protected]> Gerrit-Reviewer: Bmansurov <[email protected]> Gerrit-Reviewer: Jdlrobson <[email protected]> Gerrit-Reviewer: jenkins-bot <> _______________________________________________ MediaWiki-commits mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
