Aaron Schulz has uploaded a new change for review.
https://gerrit.wikimedia.org/r/233623
Change subject: Fixed usage of ChronologyProtector in MediaWiki
......................................................................
Fixed usage of ChronologyProtector in MediaWiki
* Placed an LB shutdown() call in dePreOutputCommit() so that the
positions are properly included in sessions before session write().
They need to be part of the synchronous updates that happen before
the user gets the response, otherwise it defeats the whole point of
the system.
Bug: T101224
Change-Id: Idf367c2aa9aae432a0c4d7cc697366aa544d77f2
---
M includes/MediaWiki.php
1 file changed, 7 insertions(+), 1 deletion(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core
refs/changes/23/233623/1
diff --git a/includes/MediaWiki.php b/includes/MediaWiki.php
index f488aa2..e9946a8 100644
--- a/includes/MediaWiki.php
+++ b/includes/MediaWiki.php
@@ -495,7 +495,13 @@
public function doPreOutputCommit() {
// Either all DBs should commit or none
ignore_user_abort( true );
- wfGetLBFactory()->commitMasterChanges();
+
+ // Commit all changes and record ChronologyProtector positions
+ $factory = wfGetLBFactory();
+ $factory->commitMasterChanges();
+ $factory->shutdown();
+
+ wfDebug( __METHOD__ . ' completed; all transactions committed'
);
}
/**
--
To view, visit https://gerrit.wikimedia.org/r/233623
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Idf367c2aa9aae432a0c4d7cc697366aa544d77f2
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Aaron Schulz <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
