jenkins-bot has submitted this change and it was merged.
Change subject: Fix the profile quoting in our content type strings
......................................................................
Fix the profile quoting in our content type strings
Occasionally a wild double quote will wander into my supply of
erstwhile domesticated double quotes. The wild ones cause all
sorts of trouble, jumping around and knocking things over. In
this case, the wild double quote went for a walkabout to the end
of its line. We're lucky it didn't fall clear off the edge.
Corral the wild double quote and replace it with a domesticated
double quote who has promised me it won't wander off.
Follow up to Ie875223014941d6eeb86c4d054e1142aacbf3254.
*In addition*, remove the `charset` parameter from the Content-Type,
since according to RFC4627 UTF-8 encoding is already the default for
application/json.
Change-Id: Ib9759b7254e15491068f5ae3449d48d30e3d9648
---
M lib/mediawiki.DOMPostProcessor.js
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Arlolra: Looks good to me, approved
GWicke: Looks good to me, but someone else must approve
jenkins-bot: Verified
diff --git a/lib/mediawiki.DOMPostProcessor.js
b/lib/mediawiki.DOMPostProcessor.js
index 7976f5f..fb9c176 100644
--- a/lib/mediawiki.DOMPostProcessor.js
+++ b/lib/mediawiki.DOMPostProcessor.js
@@ -344,7 +344,7 @@
var script = document.createElement("script");
DU.addAttributes(script, {
id: "mw-data-parsoid",
- type:
'application/json;profile="mediawiki.org/specs/data-parsoid/0.0.1;charset=utf-8"',
+ type:
'application/json;profile="mediawiki.org/specs/data-parsoid/0.0.1"',
});
script.appendChild(document.createTextNode(dp));
document.head.appendChild(script);
--
To view, visit https://gerrit.wikimedia.org/r/233835
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib9759b7254e15491068f5ae3449d48d30e3d9648
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/services/parsoid
Gerrit-Branch: master
Gerrit-Owner: Cscott <[email protected]>
Gerrit-Reviewer: Arlolra <[email protected]>
Gerrit-Reviewer: Cscott <[email protected]>
Gerrit-Reviewer: GWicke <[email protected]>
Gerrit-Reviewer: Subramanya Sastry <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
