Thiemo Mättig (WMDE) has uploaded a new change for review.
https://gerrit.wikimedia.org/r/233956
Change subject: Fix non-callable type in wgAPIModules registration
......................................................................
Fix non-callable type in wgAPIModules registration
I can not tell why this started to fail on my local mashine, because
the relevant is_callable check is there since 2014. However, I think
this is a reasonable change that should be done no matter what. A
string is usually not callable, you know?
Change-Id: I82291273a06ca8c43c688ad625f60a689e6a9c27
---
M WikibaseQualityExternalValidation.php
1 file changed, 3 insertions(+), 1 deletion(-)
git pull
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/WikibaseQualityExternalValidation
refs/changes/56/233956/1
diff --git a/WikibaseQualityExternalValidation.php
b/WikibaseQualityExternalValidation.php
index 98e9026..8366026 100755
--- a/WikibaseQualityExternalValidation.php
+++ b/WikibaseQualityExternalValidation.php
@@ -31,7 +31,9 @@
// Define API modules
$GLOBALS['wgAPIModules']['wbqevcrosscheck'] = array(
'class' =>
'WikibaseQuality\ExternalValidation\Api\RunCrossCheck',
- 'factory' =>
'WikibaseQuality\ExternalValidation\Api\RunCrossCheck::newFromGlobalState'
+ 'factory' => function( ApiMain $main, $action ) {
+ return
\WikibaseQuality\ExternalValidation\Api\RunCrossCheck::newFromGlobalState(
$main, $action );
+ }
);
// Define modules
--
To view, visit https://gerrit.wikimedia.org/r/233956
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I82291273a06ca8c43c688ad625f60a689e6a9c27
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/WikibaseQualityExternalValidation
Gerrit-Branch: master
Gerrit-Owner: Thiemo Mättig (WMDE) <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
