jenkins-bot has submitted this change and it was merged.
Change subject: Add @todo comment for I4b0e55fe
......................................................................
Add @todo comment for I4b0e55fe
In the interest of not blocking other work, I4b0e55fe worked around an
issue locally in ApiParse while filing T110269 for the larger task that
would be needed to properly fix the problem.
This adds a @todo comment referring to that task to make the situation a
bit more clear, since I4b0e55fe was merged too hastily to get the
comment included there.
Change-Id: I5be690aa5316cba1d498358635d497aa465a9972
---
M includes/api/ApiParse.php
1 file changed, 1 insertion(+), 0 deletions(-)
Approvals:
Anomie: Looks good to me, approved
jenkins-bot: Verified
diff --git a/includes/api/ApiParse.php b/includes/api/ApiParse.php
index d67655b..cce8572 100644
--- a/includes/api/ApiParse.php
+++ b/includes/api/ApiParse.php
@@ -171,6 +171,7 @@
// Don't pollute the parser cache when setting
options that aren't
// in ParserOptions::optionsHash()
+ /// @todo: This should be handled closer to the
actual cache instead of here, see T110269
$suppressCache =
$params['disablepp'] ||
$params['disablelimitreport'] ||
--
To view, visit https://gerrit.wikimedia.org/r/233968
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I5be690aa5316cba1d498358635d497aa465a9972
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Anomie <[email protected]>
Gerrit-Reviewer: Anomie <[email protected]>
Gerrit-Reviewer: Jackmcbarn <[email protected]>
Gerrit-Reviewer: Ori.livneh <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
