jenkins-bot has submitted this change and it was merged.
Change subject: maintenance: Handle errors in deleteEqualMessages.php
......................................................................
maintenance: Handle errors in deleteEqualMessages.php
Follows-up 49107fcc2.
Change-Id: I1b4b3f89a383a9b010d557ae0c6cbd767be60fb0
---
M maintenance/deleteEqualMessages.php
1 file changed, 8 insertions(+), 3 deletions(-)
Approvals:
Alex Monk: Looks good to me, approved
jenkins-bot: Verified
diff --git a/maintenance/deleteEqualMessages.php
b/maintenance/deleteEqualMessages.php
index 73e65dc..478e0d7 100644
--- a/maintenance/deleteEqualMessages.php
+++ b/maintenance/deleteEqualMessages.php
@@ -182,15 +182,20 @@
$this->output( "\n* [[$title]]" );
$page = WikiPage::factory( $title );
$error = ''; // Passed by ref
- // FIXME: Deletion failures should be reported, not
silently ignored.
- $page->doDeleteArticle( 'No longer required', false, 0,
true, $error, $user );
+ $success = $page->doDeleteArticle( 'No longer
required', false, 0, true, $error, $user );
+ if ( !$success ) {
+ $this->output( " (Failed!)" );
+ }
if ( $result['hasTalk'] && $doDeleteTalk ) {
$title = Title::makeTitle( NS_MEDIAWIKI_TALK,
$result['title'] );
$this->output( "\n* [[$title]]" );
$page = WikiPage::factory( $title );
$error = ''; // Passed by ref
- $page->doDeleteArticle( 'Orphaned talk page of
no longer required message',
+ $success = $page->doDeleteArticle( 'Orphaned
talk page of no longer required message',
false, 0, true, $error, $user );
+ if ( !$success ) {
+ $this->output( " (Failed!)" );
+ }
}
}
$this->output( "\n\ndone!\n" );
--
To view, visit https://gerrit.wikimedia.org/r/234037
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I1b4b3f89a383a9b010d557ae0c6cbd767be60fb0
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: wmf/1.26wmf19
Gerrit-Owner: Krinkle <[email protected]>
Gerrit-Reviewer: Alex Monk <[email protected]>
Gerrit-Reviewer: Parent5446 <[email protected]>
Gerrit-Reviewer: Siebrand <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
