Dbrant has uploaded a new change for review.
https://gerrit.wikimedia.org/r/234418
Change subject: Fix crash when saving a page via context menu with no network.
......................................................................
Fix crash when saving a page via context menu with no network.
Bug: T110589
Change-Id: I5fc7f3f71d8b7fdd39b69fd42013bf33f476f1cf
---
M app/src/main/java/org/wikipedia/page/PageActivityLongPressHandler.java
1 file changed, 8 insertions(+), 1 deletion(-)
git pull ssh://gerrit.wikimedia.org:29418/apps/android/wikipedia
refs/changes/18/234418/1
diff --git
a/app/src/main/java/org/wikipedia/page/PageActivityLongPressHandler.java
b/app/src/main/java/org/wikipedia/page/PageActivityLongPressHandler.java
index 62c2066..85b3dfc 100644
--- a/app/src/main/java/org/wikipedia/page/PageActivityLongPressHandler.java
+++ b/app/src/main/java/org/wikipedia/page/PageActivityLongPressHandler.java
@@ -59,10 +59,17 @@
public void onFinish(List<Section> result) {
super.onFinish(result);
- if (!activity.isFinishing()) {
+ if (!activity.isDestroyed()) {
activity.showPageSavedMessage(title.getDisplayText(),
true);
}
}
+
+ @Override
+ public void onCatch(Throwable caught) {
+ if (!activity.isDestroyed()) {
+ FeedbackUtil.showError(activity, caught);
+ }
+ }
}.execute();
}
}
--
To view, visit https://gerrit.wikimedia.org/r/234418
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I5fc7f3f71d8b7fdd39b69fd42013bf33f476f1cf
Gerrit-PatchSet: 1
Gerrit-Project: apps/android/wikipedia
Gerrit-Branch: master
Gerrit-Owner: Dbrant <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
