20after4 has uploaded a new change for review.
https://gerrit.wikimedia.org/r/234428
Change subject: Don't free the parser in the catch() block of parse()
......................................................................
Don't free the parser in the catch() block of parse()
This is the solution proposed by @bd808 to address T89532, also, it's
completely untested.
Bug: T89532
Change-Id: I9b5b47eb9d64a3d80f9c49618a362415d15071b4
(cherry picked from commit d34ed1acbe2ea58e5de59d3a18e278be0e384f8f)
---
M includes/media/XMP.php
1 file changed, 0 insertions(+), 4 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core
refs/changes/28/234428/1
diff --git a/includes/media/XMP.php b/includes/media/XMP.php
index 12550a5..5ded976 100644
--- a/includes/media/XMP.php
+++ b/includes/media/XMP.php
@@ -380,10 +380,6 @@
} catch ( Exception $e ) {
$this->logger->info( 'XMP parse error: ' . $e );
$this->results = array();
-
- if ( $allOfIt ) {
- $this->destroyXMLParser();
- }
return false;
}
if ( $allOfIt ) {
--
To view, visit https://gerrit.wikimedia.org/r/234428
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I9b5b47eb9d64a3d80f9c49618a362415d15071b4
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: 20after4 <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
